NT-1231 Creator Perspective query + View your pledge updated #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated gem activesupport and fastlane plugin and the list of dependencies of those two gems. (#894)
-- Getting backing from creator perspective
-- Refactored BackingActivity & BackingViewModel to fetch the backing from GraphQL -- Load BackingFragment in BackingActivity
-- Retrieve Backing from different queries in function of having or not the backingId
-- Filtering out null objects -- Avoid unnecessary calls
-- Changed logic for fetching the reward -- Added toolbar
-- Add test for checking BackingWrapper.
justinswart
reviewed
Jun 3, 2020
| .pledgedAt(backingGr?.pledgedOn()) | ||
| .projectId(projectId) | ||
| .sequence(backingGr?.sequence()?.toLong() ?: 0) | ||
| .shippingAmount(backingGr?.shippingAmount()?.amount().toString().toFloat()) |
There was a problem hiding this comment.
Above you are using toDouble() for the amount and in this case toFloat() would we want to perhaps stick to using toDouble()?
There was a problem hiding this comment.
I cast them to the exact same type the it's needed for the builder, the unconsistency on the types it's something we can explore as techDebt at some point I think, not sure about the impact to refactor them to use the same type at this point.
| .switchMap { it.slug()?.let { slug -> this.apolloClient.getProjectBacking(slug) } } | ||
| val backing = this.projectDataInput | ||
| .switchMap { getBackingInfo(it) } | ||
| .distinctUntilChanged() |
There was a problem hiding this comment.
Why do we need to check for uniqueness here?
There was a problem hiding this comment.
You can hit the view pledge button, then the back arrow and hit again view pledge really quick. that's why I added the check for uniqueness to not repeat the network call uneccessarly. But if you have a better way for avoiding that second call let me know!
There was a problem hiding this comment.
Ok, perhaps I'm misunderstanding the code, what I'm reading is:
.distinctUntilChanged()is placed after the call would have happened so I don't think it would prevent repeating the network call in this case?getBackingInfo(it:)appears to return the backing immediately if it's passed in so if we already have one it won't make another request - would we already have one in the scenario you're describing?
|
Cool! I was able to navigate to the new backing view: |
justinswart
reviewed
Jun 5, 2020
| .minimum(rewardAmount?: 0.0) | ||
| .description(backingGr?.reward()?.description()) | ||
| .estimatedDeliveryOn(DateTime(backingGr?.reward()?.estimatedDeliveryOn())) | ||
| .convertedMinimum(rewardAmount ?: 0.0) |
There was a problem hiding this comment.
The convertedMinimum is based on the projects currency and exchange rate, we might need this to come through from GraphQL too.
jgsamudio
approved these changes
Jun 5, 2020
8000
JadeByfield89
pushed a commit
that referenced
this pull request
Jul 22, 2020
* https://kickstarter.atlassian.net/browse/NT-1231 -- Refactored BackingActivity & BackingViewModel to fetch the backing from GraphQL -- Load BackingFragment in BackingActivity -- Changed logic for fetching the reward -- Added toolbar
Arkariang
added a commit
that referenced
this pull request
Oct 15, 2020
* NT-1231 Creator Perspective query + View your pledge updated (#895) * NT-1141: Refactor existing queries (#897) * NT-1294: RecyclerView structure for reward & Add-ons (#896) * NT-1222:Retrieve Add-ons data from Graph (#899) * NT- 1290: Add-ons UI in BackingFragment (#900) * NT-1171: Manage Pledge View Backing Info updates (#902) * NT-1290: Add-ons UI(with real data from staging) (#905) * NT-1326: Pledge header ui just for rewards (#906) * NT-1327: Header animation (#911) * NT-1171: (Fixed) Manage Pledge View Backing Info updates (#912) * NT-1326 : Add total amount back to the header (#914) * NT-1326: Reward Title going two lines (#918) * NT-1345: Bonus support validation fixes (#917) * NT-1345: Bonus support 8000 validation fixes (#917) * NT-1383: New add-ons screen (#923) * NT-1384: Add-ons list (#925) * NT-1384- AddOns query (#927) * NT-1411: Creator crash fixed (#929) * NT-1385: Add Ons Card UI (#930) * NT-1386: Stepper UI on Add-On card (#937) * NT-1422 && NT-1402 && NT-1383 && NT-1385 && NT-1382: Fix rejected (#946) * NT-1386:Rejected fix (#947) * NT-1381: Pledge header design polish (#948) * NT-1426: Android Manage Pledge View Design Polish (#949) * NT-1380 Bonus support design polish (#950) * NT-1344: Updated checkout with new mutation (#951) * NT-1344: Updated checkout with new mutation * NT- 1462&& NT-1463: UpdateBacking Mutation (#952) * NT-1462:Update pledge flow (#954) * NT-1445: Selected Reward Tag (#955) * NT-1390: Previously selected reward logic (#956) * NT-1440:Display Empty State when add-ons unavailable (#961) * NT-1453:Maximum pledge string updates (#962) * NT-1460:Update add ons selection (#959) * NT-1417: Show a native alert during Edit Reward if changes would remove add ons (#965) * NT-1387: Fix Add-Ons Available tag for Digital Reward (#970) * NT-1387: Fix - Select AddOns for digital reward (#971) * [NT-1453][NT-1344][NT-1399][NT-1509]: Fix Pledge with Digital addOns (#974) * [NT-1417][NT-1510]:Fix change reward flow (#975) * NT-1442: Android Display an error state if add-ons fail to load (#980) * NT-1516: Update the Bonus Support Base Amount (#981) * NT-1534: Sold-out add-ons (#983) * [NT-1453] Bonus Support Max Pledge String Fix (#987) * NT-1442: Hide shipping selector on network error (#986) * NT-1471 | NT-1539 - Prevent Add-ons Alert & Add Pledge Label (#991) * NT-1549 : Choose another reward flow (#993) * NT-1539: Unprompted Edit Rewards Alert (#994) * NT-1541: Updated Add-ons Quantity Not Updated (#995) * NT-1534: Android Sold-out add-ons fix (#996) * NT-1534: Modify previously backed AddOns if unavailable (#1005) * NT-606: FIX Display a string indicating backing state for creators on View/Manage Pledge screen * NT-1585:Reward with starting time restriction not started yet. (#1009) * https://kickstarter.atlassian.net/browse/NT-1587 (#1011) * NT- 1591:Blanck screen edit reward flow (#1012) * NT-1531: Android Refactor RewardUtils Java to Kotlin (#1008) * NT-1587: Improve performance (#1013) * NT-1587: Query with filtering for shippingRules (#1015) Co-authored-by: Jade Byfield <jjbyfield@gmail.com> Co-authored-by: Jade Byfield <jade@thoughtbot.com> Co-authored-by: leighdouglas <leighcdouglas1@gmail.com> Co-authored-by: jgsamudio <jonathan2457@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
🤔 Why
🛠 How
👀 See
| Before 🐛 | After 🦋 |
|
|
| | |
📋 QA
Story 📖
NT-1231 Creator Perspective query + View your pledge view