8000 NT-1534: Modify previously backed AddOns if unavailable by Arkariang · Pull Request #1005 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

NT-1534: Modify previously backed AddOns if unavailable #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 6, 2020
Merged

NT-1534: Modify previously backed AddOns if unavailable #1005

merged 5 commits into from
Oct 6, 2020

Conversation

Arkariang
Copy link
Contributor
@Arkariang Arkariang commented Oct 2, 2020 •
edited
Loading

📲 What

AC description:
Screen Shot 2020-10-05 at 8 31 16 AM

🤔 Why

  • Before if an addOn was unavailable, that addOns was filtered out and the user was unable to modify their selection
  • Now we show the unavailable addOn and we let the user modify their selection BUT just decreasing it.

🛠 How

  • Filter out Unavailable addOns in the combined list **JUST IF ** they weren't backed
  • Modified the maxLimit function, if the addOns is unavailable, the actual limit is the quantity, this way the increase button is disabled, and the user is able to ONLY DECREASE

👀 See

only_decreasing_if_unavailable
| | |

📋 QA

  • Go to bots up project, select the Upgraded bot reward, select the 2 left unit for the add on Early prototype
    & mats package -> pledge
  • Choose select another reward -> choose same reward -> make sure the add on Early prototype
    & mats package is in the list and it has 0 items left (that means is unavailable), you can just decrease the selected amount for updating that pledge

Story 📖

NT-1534

@Arkariang
- Change on the copy for the button
20223a7
@Arkariang
- Filter out unavailable addOns just when new pledge, when no backed …
8973fbb 
…addOn previously, and when choosing other reward.

In case selecting the same reward and any of the available addOns is unavailable, show it but just let the user decrease the selected quantity
@Arkariang
- Modified test
2aa1cba 
- Add new test for the new use case
@Arkariang
- Tests updated
ef9cb8d
@Arkariang
- If backed addOns, and selecting same reward, button always available
d7ab1ae 
- if selecting other reward buttons available if reward available
@Arkariang Arkariang changed the title Imartin/nt 1534 NT-1534: Modify previously backed AddOns if unavailable Oct 2, 2020
@Arkariang Arkariang marked this pull request as ready for review October 2, 2020 19:45
leighdouglas
leighdouglas reviewed Oct 6, 2020
View reviewed changes
app/src/main/java/com/kickstarter/viewmodels/BackingAddOnViewHolderViewModel.kt
* @return true -> limit for that addOn reached
* false -> still available to choose more
*/
private fun maxLimitReached(qPerAddOn: Pair<Int, Reward>): Boolean =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does the "q" in "qPerAddOn" mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quantity, and quantity Per AddOn, Would it be clearer if I change then name to quantityByAddOn? any suggestions there?

leighdouglas
leighdouglas reviewed Oct 6, 2020
View reviewed changes
app/src/test/java/com/kickstarter/viewmodels/BackingAddOnViewHolderViewModelTest.kt
@@ -158,11 +162,34 @@ class BackingAddOnViewHolderViewModelTest : KSRobolectricTestCase() {
this.disableIncreaseButton.assertValues(false, false, false, true)
}

@Test
fun increaseStepperDisable_WhenAddOnUnavailable() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would rename this test method to: disableIncreaseButton_whenAddOnUnavailble_returnsTrue()

leighdouglas
leighdouglas approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor
@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments, looks great!

@Arkariang Arkariang merged commit a32812f into feature/NT-1382-Backing-Add-Ons Oct 6, 2020
@Arkariang Arkariang deleted the imartin/NT-1534 branch October 6, 2020 15:32
Arkariang added a commit that referenced this pull request Oct 15, 2020
@Arkariang @JadeByfield89
@leighdouglas @jgsamudio
NT-1382: AddOns (#1017)
e5eb628 
* NT-1231 Creator Perspective query + View your pledge updated (#895)
* NT-1141: Refactor existing queries (#897)
* NT-1294: RecyclerView structure for reward & Add-ons (#896)
* NT-1222:Retrieve Add-ons data from Graph (#899)
* NT- 1290: Add-ons UI in BackingFragment (#900)
* NT-1171: Manage Pledge View Backing Info updates (#902)
* NT-1290: Add-ons UI(with real data from staging) (#905)
* NT-1326: Pledge header ui just for rewards (#906)
* NT-1327: Header animation (#911)
* NT-1171: (Fixed) Manage Pledge View Backing Info updates (#912)
* NT-1326 : Add total amount back to the header (#914)
* NT-1326: Reward Title going two lines (#918)
* NT-1345: Bonus support validation fixes (#917)
* NT-1345: Bonus support validation fixes (#917)
* NT-1383: New add-ons screen (#923)
* NT-1384: Add-ons list (#925)
* NT-1384- AddOns query (#927)
* NT-1411: Creator crash fixed (#929)
* NT-1385: Add Ons Card UI  (#930)
* NT-1386: Stepper UI on Add-On card (#937)
* NT-1422 && NT-1402 && NT-1383 && NT-1385 && NT-1382: Fix rejected (#946)
* NT-1386:Rejected fix (#947)
* NT-1381: Pledge header design polish (#948)
* NT-1426: Android Manage Pledge View Design Polish (#949)
* NT-1380 Bonus support design polish (#950)
* NT-1344: Updated checkout with new mutation  (#951)
* NT-1344: Updated checkout with new mutation 
* NT- 1462&& NT-1463: UpdateBacking Mutation  (#952)
* NT-1462:Update pledge flow (#954)
* NT-1445: Selected Reward Tag  (#955)
* NT-1390: Previously selected reward logic (#956)
* NT-1440:Display Empty State when add-ons unavailable (#961)
* NT-1453:Maximum pledge string updates (#962)
* NT-1460:Update add ons selection (#959)
* NT-1417: Show a native alert during Edit Reward if changes would remove add ons (#965)
* NT-1387: Fix Add-Ons Available tag for Digital Reward (#970)
* NT-1387: Fix - Select AddOns for digital reward (#971)
* [NT-1453][NT-1344][NT-1399][NT-1509]: Fix Pledge with Digital addOns  (#974)
* [NT-1417][NT-1510]:Fix change reward flow (#975)
* NT-1442: Android Display an error state if add-ons fail to load (#980)
* NT-1516: Update the Bonus Support Base Amount (#981)
* NT-1534: Sold-out add-ons (#983)
* [NT-1453] Bonus Support Max Pledge String Fix (#987)
* NT-1442: Hide shipping selector on network error (#986)
* NT-1471 | NT-1539 - Prevent Add-ons Alert & Add Pledge Label (#991)
* NT-1549 : Choose another reward flow (#993)
* NT-1539: Unprompted Edit Rewards Alert (#994)
* NT-1541: Updated Add-ons Quantity Not Updated (#995)
* NT-1534: Android Sold-out add-ons fix (#996)
* NT-1534: Modify previously backed AddOns if unavailable (#1005)
* NT-606: FIX Display a string indicating backing state for creators on View/Manage Pledge screen 
* NT-1585:Reward with starting time restriction not started yet. (#1009)
* https://kickstarter.atlassian.net/browse/NT-1587 (#1011)
* NT- 1591:Blanck screen edit reward flow (#1012)
* NT-1531: Android Refactor RewardUtils Java to Kotlin (#1008)
* NT-1587: Improve performance (#1013)
* NT-1587: Query with filtering for shippingRules (#1015)

Co-authored-by: Jade Byfield <jjbyfield@gmail.com>
Co-authored-by: Jade Byfield <jade@thoughtbot.com>
Co-authored-by: leighdouglas <leighcdouglas1@gmail.com>
Co-authored-by: jgsamudio <jonathan2457@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighdouglas leighdouglas leighdouglas approved these changes

@jgsamudio jgsamudio Awaiting requested review from jgsamudio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkariang @leighdouglas
0