8000 Fix: potential security vulnerability in one of our dependencies. by Arkariang · Pull Request #894 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: potential security vulnerability in one of our dependencies. #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2020
Merged

Fix: potential security vulnerability in one of our dependencies. #894

merged 1 commit into from
May 28, 2020

Conversation

Arkariang
Copy link
Contributor

📲 What

  • updated gem activesupport and fastlane plugin and the list of dependencies of those two gems.

🤔 Why

I hate having this warnings:

Screen Shot 2020-05-28 at 8 44 23 AM
Screen Shot 2020-05-28 at 8 44 34 AM

🛠 How

Execute bundle update activesupport
Execute bundle update fastlane

📋 QA

  • Execute ./bin/milkrun update-strings -> you should get the translation without environment issues.
  • Execute bundle exec fastlane internal -> you should have an internal release created & updated to firebase without any environment issues. Take a look into the date and hour to check is your latest internal release:

Screen Shot 2020-05-28 at 8 50 50 AM

@Arkariang Arkariang marked this pull request as ready for review May 28, 2020 16:04
@Arkariang Arkariang merged commit 759904d into master May 28, 2020
@Arkariang Arkariang deleted the imartin/update-gems branch May 28, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgsamudio jgsamudio jgsamudio approved these changes

@justinswart justinswart Awaiting requested review from justinswart

@ifbarrera ifbarrera Awaiting requested review from ifbarrera

Assignees
No one assigned
Labels
maintenance 🗜
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkariang @jgsamudio
0