[NT-1453] Bonus Support Max Pledge String Fix #987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of the pledge max.
leighdouglas
approved these changes
Sep 23, 2020
| .compose<Pair<Double, Double>>(combineLatestPair(total)) | ||
| .map { it.first > it.second } | ||
| .map { it.first >= it.second } | ||
| .distinctUntilChanged() | ||
|
|
||
| pledgeMaximumIsGone |
There was a problem hiding this comment.
Do we need to update tests for this change?
There was a problem hiding this comment.
Don't think so, we currently don't have tests for Bonus support. I can add a ticket to add them in the future
There was a problem hiding this comment.
we do have test for the PledgeMaximum is gone in PledgeFragmentViewModelTest. If all of them are passing that's nice :) . I guess there was no test for the equals amount, just higher
jgsamudio
commented
Sep 23, 2020
| @@ -896,8 +897,6 @@ interface PledgeFragmentViewModel { | |||
| } | |||
|
|
|||
| pledgeMaximum | |||
| .compose<Pair<Double, Boolean>>(combineLatestPair(pledgeMaximumIsGone)) | |||
| .map { it.first } | |||
Arkariang
approved these changes
Sep 23, 2020
Arkariang
added a commit
that referenced
this pull request
Oct 15, 2020
* NT-1231 Creator Perspective query + View your pledge updated (#895) * NT-1141: Refactor existing queries (#897) * NT-1294: RecyclerView structure for reward & Add-ons (#896) * NT-1222:Retrieve Add-ons data from Graph (#899) * NT- 1290: Add-ons UI in BackingFragment (#900) * NT-1171: Manage Pledge View Backing Info updates (#902) * NT-1290: Add-ons UI(with real data from staging) (#905) * NT-1326: Pledge header ui just for rewards (#906) * NT-1327: Header animation (#911) * NT-1171: (Fixed) Manage Pledge View Backing Info updates (#912) * NT-1326 : Add total amount back to the header (#914) * NT-1326: Reward Title going two lines (#918) * NT-1345: Bonus support validation fixes (#917) * NT-1345: Bonus support validation fixes (#917) * NT-1383: New add-ons screen (#923) * NT-1384: Add-ons list (#925) * NT-1384- AddOns query (#927) * NT-1411: Creator crash fixed (#929) * NT-1385: Add Ons Card UI (#930) * NT-1386: Stepper UI on Add-On card (#937) * NT-1422 && NT-1402 && NT-1383 && NT-1385 && NT-1382: Fix rejected (#946) * NT-1386:Rejected fix (#947) * NT-1381: Pledge header design polish (#948) * NT-1426: Android Manage Pledge View Design Polish (#949) * NT-1380 Bonus support design polish (#950) * NT-1344: Updated checkout with new mutation (#951) * NT-1344: Updated checkout with new mutation * NT- 1462&& NT-1463: UpdateBacking Mutation (#952) * NT-1462:Update pledge flow (#954) * NT-1445: Selected Reward Tag (#955) * NT-1390: Previously selected reward logic (#956) * NT-1440:Display Empty State when add-ons unavailable (#961) * NT-1453:Maximum pledge string updates (#962) * NT-1460:Update add ons selection (#959) * NT-1417: Show a native alert during Edit Reward if changes would remove add ons (#965) * NT-1387: Fix Add-Ons Available tag for Digital Reward (#970) * NT-1387: Fix - Select AddOns for digital reward (#971) * [NT-1453][NT-1344][NT-1399][NT-1509]: Fix Pledge with Digital addOns (#974) * [NT-1417][NT-1510]:Fix change reward flow (#975) * NT-1442: Android Display an error state if add-ons fail to load (#980) * NT-1516: Update the Bonus Support Base Amount (#981) * NT-1534: Sold-out add-ons (#983) * [NT-1453] Bonus Support Max Pledge String Fix (#987) * NT-1442: Hide shipping selector on network error (#986) * NT-1471 | NT-1539 - Prevent Add-ons Alert & Add Pledge Label (#991) * NT-1549 : Choose another reward flow (#993) * NT-1539: Unprompted Edit Rewards Alert (#994) * NT-1541: Updated Add-ons Quantity Not Updated (#995) * NT-1534: Android Sold-out add-ons fix (#996) * NT-1534: Modify previously backed AddOns if unavailable (#1005) * NT-606: FIX Display a string indicating backing state for creators on View/Manage Pledge screen * NT-1585:Reward with starting time restriction not started yet. (#1009) * https://kickstarter.atlassian.net/browse/NT-1587 (#1011) * NT- 1591:Blanck screen edit reward flow (#1012) * NT-1531: Android Refactor RewardUtils Java to Kotlin (#1008) * NT-1587: Improve performance (#1013) * NT-1587: Query with filtering for shippingRules (#1015) Co-authored-by: Jade Byfield <jjbyfield@gmail.com> Co-authored-by: Jade Byfield <jade@thoughtbot.com> Co-authored-by: leighdouglas <leighcdouglas1@gmail.com> Co-authored-by: jgsamudio <jonathan2457@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Fixed an issue where the maximum pledge amount is showing for the incorrect value of the max pledge.
🤔 Why
When the user adds bonus support, the max amount should be the following:
X = [max pledge amount] – [base reward + base reward shipping + addons + addons shipping]
🛠 How
The stream that determines if the bonus support amount error string should show is based off of the PledgeMaximum instead of the CurrencyMaximum.
📋 QA
Story 📖
NT-1453