8000 fix: typo in config, `SpacesAftertabs` => `SpacesAfterTabs` by hituzi-no-sippo · Pull Request #386 · editorconfig-checker/editorconfig-checker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: typo in config, SpacesAftertabs => SpacesAfterTabs #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 13, 2024
Merged

fix: typo in config, SpacesAftertabs => SpacesAfterTabs #386

merged 4 commits into from
Oct 13, 2024

Conversation

hituzi-no-sippo
Copy link
Contributor

#247

I think we should rather change this in the code to be SpacesAfterTabs as this is the more accurate name.
Would you be willing to provide a PR for this too?

@codecov Codecov
Copy link
codecov bot commented Oct 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.89%. Comparing base (c96de80) to head (f2fcec8).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
+ Coverage   86.83%   86.89%   +0.05%     
==========================================
  Files          10       10              
  Lines         699      702       +3     
==========================================
+ Hits          607      610       +3     
  Misses         63       63              
  Partials       29       29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

klaernie
klaernie requested changes Oct 5, 2024
View reviewed changes
Copy link
Member
@klaernie klaernie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a breaking change we should provide a transition period in which we accept the old name in the config file, but warn that this property has been renamed.

hituzi-no-sippo
hituzi-no-sippo commented Oct 9, 2024
View reviewed changes
@hituzi-no-sippo
Copy link
Contributor Author

Thanks for your review.

I have the above two questions.
Would you mind answering them if you don't mind?
I am a beginner in Golang. So I don't know what to do about the above two points.

This was referenced Oct 11, 2024
Merged
Closed
@theoludwig theoludwig changed the title fix!: fix typos fix: typo in config, SpacesAftertabs => SpacesAfterTabs Oct 11, 2024
@abuzaforfagun abuzaforfagun mentioned this pull request Oct 11, 2024
Merged
theoludwig
theoludwig approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member
@theoludwig theoludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

It looks good to me. 😄

@theoludwig theoludwig added this to the v3.1.0 milestone Oct 13, 2024
@theoludwig theoludwig mentioned this pull request Oct 13, 2024
Open
@klaernie
Copy link
Member

As much as it pains me (because I will have to rebase something ;) ) it's a good change to have! Thanks for implementing, @hituzi-no-sippo!

@theoludwig theoludwig merged commit 25e3542 into editorconfig-checker:main Oct 13, 2024
5 checks passed
@hituzi-no-sippo hituzi-no-sippo deleted the fix/fix-typos branch October 13, 2024 18:20
This was referenced Jan 5, 2025
Closed
Closed
@editorconfig-checker-bot editorconfig-checker-bot mentioned this pull request Jan 6, 2025
Merged
@BrewTestBot BrewTestBot mentioned this pull request Jan 8, 2025
Merged
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Jan 10, 2025
Update module github.com/editorconfig-checker/editorconfig-checker/v3…
98edc27 
…/cmd/editorconfig-checker to v3.1.1 (forgejo) (#6520)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [github.com/editorconfig-checker/editorconfig-checker/v3/cmd/editorconfig-checker](https://github.com/editorconfig-checker/editorconfig-checker) | minor | `v3.0.3` -> `v3.1.1` |

---

### Release Notes

<details>
<summary>editorconfig-checker/editorconfig-checker (github.com/editorconfig-checker/editorconfig-checker/v3/cmd/editorconfig-checker)</summary>

### [`v3.1.1`](https://github.com/editorconfig-checker/editorconfig-checker/releases/tag/v3.1.1)

[Compare Source](editorconfig-checker/editorconfig-checker@v3.1.0...v3.1.1)

##### Bug Fixes

-   dockerfile expected binary at /, not /usr/bin/ [#&#8203;410](editorconfig-checker/editorconfig-checker#410) ([#&#8203;411](editorconfig-checker/editorconfig-checker#411)) ([2c82197](editorconfig-checker/editorconfig-checker@2c82197))

### [`v3.1.0`](https://github.com/editorconfig-checker/editorconfig-checker/releases/tag/v3.1.0)

[Compare Source](editorconfig-checker/editorconfig-checker@v3.0.3...v3.1.0)

##### Features

-   add zip version when compressing all binaries ([#&#8203;321](editorconfig-checker/editorconfig-checker#321)) ([#&#8203;362](editorconfig-checker/editorconfig-checker#362)) ([f1bb625](editorconfig-checker/editorconfig-checker@f1bb625))
-   consolidate adjacent error messages ([#&#8203;360](editorconfig-checker/editorconfig-checker#360)) ([cf4ae1c](editorconfig-checker/editorconfig-checker@cf4ae1c))
-   editorconfig-checker-disable-next-line ([#&#8203;363](editorconfig-checker/editorconfig-checker#363)) ([6116ec6](editorconfig-checker/editorconfig-checker@6116ec6))
-   provide Codeclimate compatible report fromat ([#&#8203;367](editorconfig-checker/editorconfig-checker#367)) ([282c315](editorconfig-checker/editorconfig-checker@282c315))
-   support `.editorconfig-checker.json` config ([#&#8203;375](editorconfig-checker/editorconfig-checker#375)) ([cb0039c](editorconfig-checker/editorconfig-checker@cb0039c))

##### Bug Fixes

-   actually use the correct end marker ([#&#8203;405](editorconfig-checker/editorconfig-checker#405)) ([3c03499](editorconfig-checker/editorconfig-checker@3c03499))
-   add `.ecrc` deprecation warning ([#&#8203;389](editorconfig-checker/editorconfig-checker#389)) ([d33b81c](editorconfig-checker/editorconfig-checker@d33b81c))
-   this release-please marker ([#&#8203;403](editorconfig-checker/editorconfig-checker#403)) ([617c6d4](editorconfig-checker/editorconfig-checker@617c6d4))
-   typo in config, `SpacesAftertabs` => `SpacesAfterTabs` ([#&#8203;386](editorconfig-checker/editorconfig-checker#386)) ([25e3542](editorconfig-checker/editorconfig-checker@25e3542))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "* 0-3 * * *" (UTC), Automerge - "* 0-3 * * *" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45My4wIiwidXBkYXRlZEluVmVyIjoiMzkuOTMuMCIsInRhcmdldEJyYW5jaCI6ImZvcmdlam8iLCJsYWJlbHMiOlsiZGVwZW5kZW5jeS11cGdyYWRlIiwidGVzdC9ub3QtbmVlZGVkIl19-->

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6520
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
@nietras
Copy link
nietras commented May 23, 2025

This change breaks my build using Super Linter and I don't know how to fix given I don't have SpacesAftertabs in the file 😅

https://github.com/nietras/Sep/actions/runs/15208581410/job/42777265663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klaernie klaernie klaernie approved these changes

@theoludwig theoludwig theoludwig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hituzi-no-sippo @klaernie @nietras @theoludwig
0