chore(main): release 3.1.0 #402
Conversation
|
@klaernie I've used my GitHub token, instead of the one already defined, as it was not working, "Bad credentials" (ref: https://github.com/editorconfig-checker/editorconfig-checker/actions/runs/12623086839/job/35171698632). Also, the CI is failing, it seems, that it's replacing the |
| @@ -28,15 +28,15 @@ func TestGetErrorCount(t *testing.T) { | |||
| FilePath: "some/path", | |||
| Errors: []ValidationError{ | |||
| { | |||
| LineNumber: 1, | |||
| LineNumber: 3, | |||
There was a problem hiding this comment.
It should not replace LineNumber by 3 here.
Do you have an idea, why the bot does that? @klaernie
| @@ -19,7 +19,7 @@ import ( | |||
|
|
|||
| func TestGetErrorCount(t *testing.T) { | |||
| count := GetErrorCount([]ValidationErrors{}) | |||
| if count != 0 { | |||
| if count != 3 { | |||
There was a problem hiding this comment.
I don't get this change, nor anything that come next (about line and count)
I mean how is it related to bumping version 🤔
There was a problem hiding this comment.
Yes, I agree. We should check what went wrong with the Release Please bot.
There was a problem hiding this comment.
Oh shit - I forgot to replace the start by stop in line 15
8fe414f to
4b60598
Compare
|
Let's close this one, and rerun the action on top of the last commit, IMHO that should create a new PR which does not attempt to replace every number |
🤖 I have created a release beep boop
3.1.0 (2025-01-05)
Features
.editorconfig-checker.jsonconfig (#375) (cb0039c)Bug Fixes
.ecrcdeprecation warning (#389) (d33b81c)SpacesAftertabs=>SpacesAfterTabs(#386) (25e3542)This PR was generated with Release Please. See documentation.