8000 fix: add `.ecrc` deprecation warning by abuzaforfagun · Pull Request #389 · editorconfig-checker/editorconfig-checker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: add .ecrc deprecation warning #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 13, 2024
Merged

fix: add .ecrc deprecation warning #389

merged 6 commits into from
Oct 13, 2024

Conversation

abuzaforfagun
Copy link
Contributor
@abuzaforfagun abuzaforfagun commented Oct 11, 2024 •
edited by theoludwig
Loading

Fixes #388

In #375, a new configuration file has been added: .editorconfig-checker.json.

In v4.0.0, we plan to drop the naming ec to use editorconfig-checker (#371), so we thought that we should deprecate usage of .ecrc, so that we can remove it in v4.0.0.

However, currently it is only deprecated in the README.md, we should deprecate it at runtime, by emitting a warning so that it will be easier for users to upgrade.

Similarly, it has been suggested to emit warnings in #386.

ccoVeille
ccoVeille requested changes Oct 12, 2024
View reviewed changes
ccoVeille
ccoVeille reviewed Oct 12, 2024
View reviewed changes
@theoludwig theoludwig changed the title Add .ecrc deprecation warning fix: add .ecrc deprecation warning Oct 12, 2024
theoludwig
theoludwig approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member
@theoludwig theoludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. 😄

LGTM, with a green CI.

ccoVeille
ccoVeille reviewed Oct 12, 2024
View reviewed changes
@theoludwig
Copy link
Member

I think, that you will need to rebase and git push --force to have a green CI.

@abuzaforfagun abuzaforfagun force-pushed the ecrc-warning branch 2 times, most recently from 6815904 to 6bc5503 Compare October 12, 2024 18:40
@klaernie
Copy link
Member

@abuzaforfagun : Why are all commits marked as breaking changes?

@codecov Codecov
Copy link
codecov bot commented Oct 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.89%. Comparing base (25e3542) to head (95b3503).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #389   +/-   ##
=======================================
  Coverage   86.89%   86.89%           
=======================================
  Files          10       10           
  Lines         702      702           
=======================================
  Hits          610      610           
  Misses         63       63           
  Partials       29       29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theoludwig
Copy link
Member

@abuzaforfagun : Why are all commits marked as breaking changes?

It will be fine, we will be able to "Squash and Merge" with the PR title as the commit message.
But yes, this change is not a breaking change, and the whole purpose of this change is to make the future planned breaking change less "painful".

@theoludwig theoludwig mentioned this pull request Oct 13, 2024
Open
@theoludwig theoludwig requested a review from ccoVeille October 13, 2024 10:26
ccoVeille
ccoVeille requested changes Oct 13, 2024
View reviewed changes
@theoludwig theoludwig mentioned this pull request Oct 13, 2024
Merged
klaernie
klaernie approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member
@klaernie klaernie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L 8000 ooks good now!

@theoludwig theoludwig merged commit d33b81c into editorconfig-checker:main Oct 13, 2024
5 checks passed
@abuzaforfagun abuzaforfagun deleted the ecrc-warning branch October 13, 2024 21:46
This was referenced Jan 5, 2025
Closed
Closed
@editorconfig-checker-bot editorconfig-checker-bot mentioned this pull request Jan 6, 2025
Merged
@BrewTestBot BrewTestBot mentioned this pull request Jan 8, 2025
Merged
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Jan 10, 2025
Update module github.com/editorconfig-checker/editorconfig-checker/v3…
98edc27 
…/cmd/editorconfig-checker to v3.1.1 (forgejo) (#6520)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [github.com/editorconfig-checker/editorconfig-checker/v3/cmd/editorconfig-checker](https://github.com/editorconfig-checker/editorconfig-checker) | minor | `v3.0.3` -> `v3.1.1` |

---

### Release Notes

<details>
<summary>editorconfig-checker/editorconfig-checker (github.com/editorconfig-checker/editorconfig-checker/v3/cmd/editorconfig-checker)</summary>

### [`v3.1.1`](https://github.com/editorconfig-checker/editorconfig-checker/releases/tag/v3.1.1)

[Compare Source](editorconfig-checker/editorconfig-checker@v3.1.0...v3.1.1)

##### Bug Fixes

-   dockerfile expected binary at /, not /usr/bin/ [#&#8203;410](editorconfig-checker/editorconfig-checker#410) ([#&#8203;411](editorconfig-checker/editorconfig-checker#411)) ([2c82197](editorconfig-checker/editorconfig-checker@2c82197))

### [`v3.1.0`](https://github.com/editorconfig-checker/editorconfig-checker/releases/tag/v3.1.0)

[Compare Source](editorconfig-checker/editorconfig-checker@v3.0.3...v3.1.0)

##### Features

-   add zip version when compressing all binaries ([#&#8203;321](editorconfig-checker/editorconfig-checker#321)) ([#&#8203;362](editorconfig-checker/editorconfig-checker#362)) ([f1bb625](editorconfig-checker/editorconfig-checker@f1bb625))
-   consolidate adjacent error messages ([#&#8203;360](editorconfig-checker/editorconfig-checker#360)) ([cf4ae1c](editorconfig-checker/editorconfig-checker@cf4ae1c))
-   editorconfig-checker-disable-next-line ([#&#8203;363](editorconfig-checker/editorconfig-checker#363)) ([6116ec6](editorconfig-checker/editorconfig-checker@6116ec6))
-   provide Codeclimate compatible report fromat ([#&#8203;367](editorconfig-checker/editorconfig-checker#367)) ([282c315](editorconfig-checker/editorconfig-checker@282c315))
-   support `.editorconfig-checker.json` config ([#&#8203;375](editorconfig-checker/editorconfig-checker#375)) ([cb0039c](editorconfig-checker/editorconfig-checker@cb0039c))

##### Bug Fixes

-   actually use the correct end marker ([#&#8203;405](editorconfig-checker/editorconfig-checker#405)) ([3c03499](editorconfig-checker/editorconfig-checker@3c03499))
-   add `.ecrc` deprecation warning ([#&#8203;389](editorconfig-checker/editorconfig-checker#389)) ([d33b81c](editorconfig-checker/editorconfig-checker@d33b81c))
-   this release-please marker ([#&#8203;403](editorconfig-checker/editorconfig-checker#403)) ([617c6d4](editorconfig-checker/editorconfig-checker@617c6d4))
-   typo in config, `SpacesAftertabs` => `SpacesAfterTabs` ([#&#8203;386](editorconfig-checker/editorconfig-checker#386)) ([25e3542](editorconfig-checker/editorconfig-checker@25e3542))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "* 0-3 * * *" (UTC), Automerge - "* 0-3 * * *" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45My4wIiwidXBkYXRlZEluVmVyIjoiMzkuOTMuMCIsInRhcmdldEJyYW5jaCI6ImZvcmdlam8iLCJsYWJlbHMiOlsiZGVwZW5kZW5jeS11cGdyYWRlIiwidGVzdC9ub3QtbmVlZGVkIl19-->

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6520
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theoludwig theoludwig theoludwig approved these changes

@ccoVeille ccoVeille ccoVeille approved these changes

@klaernie klaernie klaernie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate by a warning the .ecrc configuration file
4 participants
@abuzaforfagun @theoludwig @klaernie @ccoVeille
0