8000 docs: fix typo by hituzi-no-sippo · Pull Request #247 · editorconfig-checker/editorconfig-checker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: fix typo #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: fix typo #247

wants to merge 1 commit into from

Conversation

hituzi-no-sippo
Copy link
Contributor

No description provided.

mstruebing
mstruebing reviewed Jan 21, 2023
View reviewed changes
Copy link
Member
@mstruebing mstruebing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank you for your contribution and the pull request.
I think we should rather change this in the code to be SpacesAfterTabs as this is the more accurate name.
Would you be willing to provide a PR for this too?

@hituzi-no-sippo
Copy link
Contributor Author

Thank you for response.

Hey, thank you for your contribution and the pull request.
I think we should rather change this in the code to be SpacesAfterTabs as this is the more accurate name.
Would you be willing to provide a PR for this too?

If you are okay with the following conditions, I will provide this PR:

  • I am a beginner in Go language.
  • I plan to create the PR starting in February.

If you would like, please answer the following a question:

  • Is this PR Breaking change?

@mstruebing
Copy link
Member

In theory, it is a breaking change as this changes the API.
But as this is only the result of a typo, I would say it is a fix and would approve it as a fix commit.

@hituzi-no-sippo
Copy link
Contributor Author

Sorry for the late reply.

Would you be willing to provide a PR for this too?

I had missed it.

I should just create a separate Pull Request for the breaking change to rename SpacesAftertabs to SpacesAfterTabs.

And should I close this Pull Request?

@mstruebing
Copy link
Member

I'll close it. Would be great if you could provide this change in a separate PR 👍

@mstruebing mstruebing closed this Feb 11, 2023
@hituzi-no-sippo hituzi-no-sippo mentioned this pull request Oct 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstruebing mstruebing mstruebing left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hituzi-no-sippo @mstruebing
0