feat: support .editorconfig-checker.json config
#375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feel free to review also @klaernie 😄 |
07928ce to
5e7133f
Compare
theoludwig
commented
Sep 8, 2024
.ecrc.json, .editorconfig-checkerrc, .editorconfig-checkerrc.json
theoludwig
commented
Sep 8, 2024
5e7133f to
5a09d6f
Compare
.editorconfig-checker.json config
klaernie
requested changes
Sep 8, 2024
There was a problem hiding this comment.
The technical implementation of searching for config files is correct this way, I would only request that we search for our ideal config file name first (.editorconfig-checker(rc)?.json), then drop the .json suffix (if we actually want to encourage that behaviour) and that fail back to loading .ecrc.
This way users can test their migration to the new file format, and do not get surprised by adding a new config with a syntax error, checking their CI and noticing no problems, then drop their existing config and suddenly run into a problem as the syntax error now gets noticed.
Also having one filename would be better for adding a JSON schema (#194)
ccoVeille
reviewed
Sep 8, 2024
Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
ccoVeille
reviewed
Sep 8, 2024
ccoVeille
approved these changes
Sep 8, 2024
klaernie
approved these changes
Sep 8, 2024
Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
ccoVeille
approved these changes
Sep 8, 2024
This was referenced Oct 11, 2024
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Jan 10, 2025
…/cmd/editorconfig-checker to v3.1.1 (forgejo) (#6520) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [github.com/editorconfig-checker/editorconfig-checker/v3/cmd/editorconfig-checker](https://github.com/editorconfig-checker/editorconfig-checker) | minor | `v3.0.3` -> `v3.1.1` | --- ### Release Notes <details> <summary>editorconfig-checker/editorconfig-checker (github.com/editorconfig-checker/editorconfig-checker/v3/cmd/editorconfig-checker)</summary> ### [`v3.1.1`](https://github.com/editorconfig-checker/editorconfig-checker/releases/tag/v3.1.1) [Compare Source](editorconfig-checker/editorconfig-checker@v3.1.0...v3.1.1) ##### Bug Fixes - dockerfile expected binary at /, not /usr/bin/ [#​410](editorconfig-checker/editorconfig-checker#410) ([#​411](editorconfig-checker/editorconfig-checker#411)) ([2c82197](editorconfig-checker/editorconfig-checker@2c82197)) ### [`v3.1.0`](https://github.com/editorconfig-checker/editorconfig-checker/releases/tag/v3.1.0) [Compare Source](editorconfig-checker/editorconfig-checker@v3.0.3...v3.1.0) ##### Features - add zip version when compressing all binaries ([#​321](editorconfig-checker/editorconfig-checker#321)) ([#​362](editorconfig-checker/editorconfig-checker#362)) ([f1bb625](editorconfig-checker/editorconfig-checker@f1bb625)) - consolidate adjacent error messages ([#​360](editorconfig-checker/editorconfig-checker#360)) ([cf4ae1c](editorconfig-checker/editorconfig-checker@cf4ae1c)) - editorconfig-checker-disable-next-line ([#​363](editorconfig-checker/editorconfig-checker#363)) ([6116ec6](editorconfig-checker/editorconfig-checker@6116ec6)) - provide Codeclimate compatible report fromat ([#​367](editorconfig-checker/editorconfig-checker#367)) ([282c315](editorconfig-checker/editorconfig-checker@282c315)) - support `.editorconfig-checker.json` config ([#​375](editorconfig-checker/editorconfig-checker#375)) ([cb0039c](editorconfig-checker/editorconfig-checker@cb0039c)) ##### Bug Fixes - actually use the correct end marker ([#​405](editorconfig-checker/editorconfig-checker#405)) ([3c03499](editorconfig-checker/editorconfig-checker@3c03499)) - add `.ecrc` deprecation warning ([#​389](editorconfig-checker/editorconfig-checker#389)) ([d33b81c](editorconfig-checker/editorconfig-checker@d33b81c)) - this release-please marker ([#​403](editorconfig-checker/editorconfig-checker#403)) ([617c6d4](editorconfig-checker/editorconfig-checker@617c6d4)) - typo in config, `SpacesAftertabs` => `SpacesAfterTabs` ([#​386](editorconfig-checker/editorconfig-checker#386)) ([25e3542](editorconfig-checker/editorconfig-checker@25e3542)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* 0-3 * * *" (UTC), Automerge - "* 0-3 * * *" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45My4wIiwidXBkYXRlZEluVmVyIjoiMzkuOTMuMCIsInRhcmdldEJyYW5jaCI6ImZvcmdlam8iLCJsYWJlbHMiOlsiZGVwZW5kZW5jeS11cGdyYWRlIiwidGVzdC9ub3QtbmVlZGVkIl19--> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6520 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org> Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #306