series/M1i #1351
Merged
series/M1i #1351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # parser-typechecker/tests/Suite.hs
# Conflicts: # parser-typechecker/tests/Suite.hs
…rors/warnings # Conflicts: # parser-typechecker/src/Unison/Codebase/Editor/HandleInput.hs
example: (probably helpful to suppress git output, print out a pr.load command, and show a deeper diff) .> pr.create https://github.com/unisonweb/base https://github.com/puffnfresh/base ⚙ git clone 'https://github.com/unisonweb/base' /Users/arya/.cache/unisonlanguage/gitfiles/q0rume4r1p1lc5tut0gcbbcvndjgr8ai0qst6ej9bdjr1vcgmtueo0103oi4kt4tr0m1vok5sbkk91g1qcr2og9pit3rp8ceeq752r8/HEAD Cloning into '/Users/arya/.cache/unisonlanguage/gitfiles/q0rume4r1p1lc5tut0gcbbcvndjgr8ai0qst6ej9bdjr1vcgmtueo0103oi4kt4tr0m1vok5sbkk91g1qcr2og9pit3rp8ceeq752r8/HEAD'... remote: Enumerating objects: 2664, done. remote: Counting objects: 100% (2664/2664), done. remote: Compressing objects: 100% (1822/1822), done. remote: Total 2664 (delta 811), reused 2619 (delta 770), pack-reused 0 Receiving objects: 100% (2664/2664), 909.77 KiB | 12.81 MiB/s, done. Resolving deltas: 100% (811/811), done. Checking out files: 100% (4512/4512), done. ⚙ git -C /Users/arya/.cache/unisonlanguage/gitfiles/q0rume4r1p1lc5tut0gcbbcvndjgr8ai0qst6ej9bdjr1vcgmtueo0103oi4kt4tr0m1vok5sbkk91g1qcr2og9pit3rp8ceeq752r8/HEAD rev-parse --git-dir .git ⚙ git -C /Users/arya/.cache/unisonlanguage/gitfiles/q0rume4r1p1lc5tut0gcbbcvndjgr8ai0qst6ej9bdjr1vcgmtueo0103oi4kt4tr0m1vok5sbkk91g1qcr2og9pit3rp8ceeq752r8/HEAD fetch 'https://github.com/unisonweb/base' From https://github.com/unisonweb/base * branch HEAD -> FETCH_HEAD ⚙ git clone 'https://github.com/puffnfresh/base' /Users/arya/.cache/unisonlanguage/gitfiles/sdmhi6m7r9a4qtilfhq82tfhv9u9f4sfhmtd8pop8gdtdb61ralcusd2p3r8btcf1o3gc5di3nhlor3utjg3n288ov1u1vud417ds5o/HEAD Cloning into '/Users/arya/.cache/unisonlanguage/gitfiles/sdmhi6m7r9a4qtilfhq82tfhv9u9f4sfhmtd8pop8gdtdb61ralcusd2p3r8btcf1o3gc5di3nhlor3utjg3n288ov1u1vud417ds5o/HEAD'... remote: Enumerating objects: 2229, done. remote: Counting objects: 100% (2229/2229), done. remote: Compressing objects: 100% (1635/1635), done. remote: Total 2229 (delta 542), reused 2210 (delta 523), pack-reused 0 Receiving objects: 100% (2229/2229), 739.76 KiB | 9.36 MiB/s, done. Resolving deltas: 100% (542/542), done. Checking out files: 100% (4572/4572), done. ⚙ git -C /Users/arya/.cache/unisonlanguage/gitfiles/sdmhi6m7r9a4qtilfhq82tfhv9u9f4sfhmtd8pop8gdtdb61ralcusd2p3r8btcf1o3gc5di3nhlor3utjg3n288ov1u1vud417ds5o/HEAD rev-parse --git-dir .git ⚙ git -C /Users/arya/.cache/unisonlanguage/gitfiles/sdmhi6m7r9a4qtilfhq82tfhv9u9f4sfhmtd8pop8gdtdb61ralcusd2p3r8btcf1o3gc5di3nhlor3utjg3n288ov1u1vud417ds5o/HEAD fetch 'https://github.com/puffnfresh/base' From https://github.com/puffnfresh/base * branch HEAD -> FETCH_HEAD + Adds / updates: Either.swap Tuple.swap Weighted.eithers Weighted.tuples .>
- Unison doesn't seem to work with GHC 8.8 right now, so e.g.
`cabal v2-configure --with-ghc=ghc-8.6.5`
to set up if 8.6 isn't the `ghc` you have in your path. This
doesn't go in the global project, though, I think, because it's
specific to the local machine, and I'm not aware of cabal
managing multiple GHC versions automatically (although I don't
pay close attention).
Remove Input from Success
…-file Remove Input from NoUnisonFile
Remove term names from evaluation in docs
EDBE
Exploded Codebase.referencesByPrefix into three functions: - referencesByPrefix :: Text -> m (Set Reference.Id) + termReferencesByPrefix :: ShortHash -> m (Set Reference.Id) + typeReferencesByPrefix :: ShortHash -> m (Set Reference.Id) + termReferentsByPrefix :: ShortHash -> m (Set (Referent' Reference.Id)) for top-level terms, top-level types, and for Ref/Con mix. They only return "derived" references, the thinking is that builtins will come from a higher level api. Exploded Command.ReferencesByShortHash into three functions - ReferencesByShortHash :: ShortHash -> Command m i v (Set Reference.Id) + TypeReferencesByShortHash :: ShortHash -> Command m i v (Set Reference) + TermReferencesByShortHash :: ShortHash -> Command m i v (Set Reference) + TermReferentsByShortHash :: ShortHash -> Command m i v (Set Referent) I actually don't remember why it was ok that it was Reference.Id before but isn't now. Maybe we hadn't wanted to auto-complete Builtin names? I don't remember. controversial? * Added a type arg `r` to `Referent`; type alias and patterns for compat. * Deleted BranchUtil.getTermByShortHash because I'm guessing we no longer want to limit such searches to the branch? Uncertain. * Reference.fromShortHash rejects inputs with ctorIds in them; seemed better than ignoring them, but I could imagine there being a case for each.
- give _all_ Abs nodes in the resulting lambda chain the annotation of the case body (not just the outer node)
Fix Branch.updateChildren to not elide empty branches with history
…for suggestions!
…annotation correct annotation of match cases to always include the case body
Some nice cleanup of `stepManyAt0` and friends
- simplify resolveHHQS'Referents - add missing logic to TermReferentsByShortHash - don't pass Codebase just to get deserializers - improve transcript prose
supporting hashes in `alias`; and names and builtins in `replace`
|
@aryairani |
|
@anovstrup Yeah; I don't know how to find a list of PRs by merge date, so sometimes I catch stray ones that were discussed after M1h. |
Ignore ctor/term collisions for dupes
Add title guidelines to PR template
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks (in no particular order) to @pete-ts, @mitchellwrosen, @bontaq, @atacratic, @anovstrup, @pt2121, @anchpop, @Dandandan, @moses-alexander, for your contributions to this release!
New features:
pull-request.createandpull-request.loadcommands to support PR workflows (Unabbreviate pr.{create,load} #1328, implement pr.create / pr.load #1197, Refactor pull / merge / pr.load #1209)alias.manycommand lets you copy multiple definitions' relative names at once to a destination namespace. (implementalias.many#1236)backcommand to jump to the namespace you lastcded from. (implements thebackcommand using a stack of currentNamespace #1294):hide:alloption forunisonanducmfences in transcripts (Add ":hide:all" option for unison and ucm fences in transcripts #1167)allow
Changed behavior:
case/ofsyntax tomatch/with(Replace case-of with match-with #1214)linkandunlinkargument order has flipped fromlink <metadata> <definition>tolink <def1> [<def2> ...] <metadata>(Allowlinkandunlinkto take numbered range arguments #1208, link command that accepts 1 or more source definitions #1127)casessyntax to replacex -> case x of(Lambda-casecasessyntax #1192)alias.type/alias.term/replace.type/replace.term(supporting hashes inalias; and names and builtins inreplace#1334)Fixes:
pushandpull(design:push/pullare sluggish #1281, check declPath before writing decls #1302)add/updateto create aliases without a big fuss (allowadd/updateto create aliases #1254)lswasn't displaying patches, + cleanup #1170, addresses the typo in 'delimiter' #1187, add some missing spaces to HandleInput.inputDescription #1222, avoidshowing arrays inHandleInput.inputDescription#1223, replace auto-derived Ord HQ instance which had orderedzbeforea#x#1227, correct annotation of match cases to always include the case body #1331 )