8000 `ls` wasn't displaying patches, + cleanup by aryairani · Pull Request #1170 · unisonweb/unison · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ls wasn't displaying patches, + cleanup #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2020
Merged

ls wasn't displaying patches, + cleanup #1170

merged 1 commit into from
Jan 22, 2020

Conversation

aryairani
Copy link
Contributor
@aryairani aryairani commented Jan 22, 2020 •
edited
Loading

Primarily wanted to get eliminate {-# OPTIONS_GHC -Wno-unused-local-binds #-} (towards #1111), and found this dead code + bug in the process.

Sample output:
image

@aryairani aryairani added the ready-to-merge Apply this to a PR and it will get merged automatically once CI passes and 1 reviewer has approved label Jan 22, 2020
@aryairani
Copy link
Contributor Author
aryairani commented Jan 22, 2020 •
edited
Loading

Side note: I think we originally envisioned listing the number of replacements in the patch or something, using some not-completely-incorrect version of patchCount, but then got lazy because it required loading the patch monadically. 😬

@mergify mergify bot merged commit fe5fa73 into master Jan 22, 2020
@aryairani aryairani mentioned this pull request Mar 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchellwrosen mitchellwrosen mitchellwrosen approved these changes

Assignees
No one assigned
Labels
ready-to-merge Apply this to a PR and it will get merged automatically once CI passes and 1 reviewer has approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aryairani @mitchellwrosen
0