Align the arrows when pretty-printing match cases #1278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchiusano
approved these changes
Feb 27, 2020
Requires tooling support for sanity. I have a generic alignment function mapped to cmd-\ because I thrive on it so much. |
pchiusano
reviewed
Feb 27, 2020
There was a problem hiding this comment.
@atacratic - reminded that it’s nice that you’ve got this little test harness that lets you easily add/alter examples. So you can make tweaks like this and then test them with pretty low friction
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change:
After this change:
If all the actual match bodies are line-broken (like the
2 | xcase above) then we still align the arrows even though it's maybe a bit weird, but I think it's OK:Proximate cause for PR: https://twitter.com/phonytope/status/1232769219881652224 😄