8000 Ignore ctor/term collisions for dupes by runarorama · Pull Request #1352 · unisonweb/unison · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ignore ctor/term collisions for dupes #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Ignore ctor/term collisions for dupes #1352

merged 1 commit into from
Mar 12, 2020

Conversation

runarorama
Copy link
Contributor
@runarorama runarorama commented Mar 12, 2020

Fixes #660

Before this fix, saving a file that contains an ability already in the codebase would fail with a cryptic error message.

After this fix, abilities already in the codebase are just ignored.

@runarorama runarorama requested a review from aryairani March 12, 2020 19:18
Copy link
Contributor
@aryairani aryairani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome — if you think the comment warrants an update, I'd do that; otherwise okay.

@aryairani aryairani mentioned this pull request Mar 12, 2020
@runarorama runarorama merged commit 1ac8b6a into master Mar 12, 2020
@runarorama runarorama deleted the bug/660 branch March 12, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

file slurp message gives incorrect failure warning for a generated function
2 participants
0