[EPIC] Triggerable Withdrawals #1018
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardhat Unit Tests Coverage SummaryDiff against masterResults for commit: 2a25c7a Minimum allowed coverage is ♻️ This comment has been updated with latest results |
skhomuti
requested changes
May 7, 2025
Comment on lines
+403
to
+405
| function _slotToTimestamp(uint64 slot) internal view returns (uint256) { | ||
| return GENESIS_TIME + slot * SECONDS_PER_SLOT; | ||
| } |
Check warning
Code scanning / Slither
Potential Arithmetic Overflow Medium
…ory method changed
…very-history-optimization New way to store delivery history in VEB
…ggerable-exits-fix-verifier
…verifier Feat/triggerable exits fix verifier
…in-unpack fix: exclude max batch size check from unpack/triggerExits methods
Description to external methods & constants
F4ever
reviewed
6D47
May 21, 2025
F4ever
reviewed
May 21, 2025
F4ever
reviewed
May 21, 2025
…guration management
…rom-sr refactor: remove deprecated refunded validators count functionality
…into feat/tw-deploy-holesky
feat: TW Refactor Deploy Script
…wv-comment feat: update addWithdrawalRequests method comment
fix: bump accounting oracle initial version to 3
Refactor/abs contract imports
feat(TW): deploy separate gate seals for WQ, VEBO and TWG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces an potential implementation of EIP-7685: General Purpose Execution Layer Requests. Specifically, it implements EIP-7002: Execution Layer Triggerable Withdrawals within the Lido WithdrawalVault contract, which serves as the withdrawal credentials address for Lido validators.