8000 fix: bump accounting oracle initial version to 3 by eddort · Pull Request #1204 · lidofinance/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: bump accounting oracle initial version to 3 #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

fix: bump accounting oracle initial version to 3 #1204

merged 1 commit into from
Jun 24, 2025

Conversation

eddort
Copy link
Member
@eddort eddort commented Jun 24, 2025

No description provided.

@eddort eddort requested a review from a team as a code owner June 24, 2025 16:13
@eddort eddort added the valset Updates from the ValSet Tech team label Jun 24, 2025
@github-actions GitHub Actions
Copy link

badge

Hardhat Unit Tests Coverage Summary

Filename                                                       Stmts    Miss  Cover    Missing
-----------------------------------------------------------  -------  ------  -------  ---------
contracts/0.4.24/Lido.sol                                        212       0  100.00%
contracts/0.4.24/StETH.sol                                        72       0  100.00%
contracts/0.4.24/StETHPermit.sol                                  15       0  100.00%
contracts/0.4.24/lib/Packed64x4.sol                                5       0  100.00%
contracts/0.4.24/lib/SigningKeys.sol                              36       0  100.00%
contracts/0.4.24/lib/StakeLimitUtils.sol                          37       0  100.00%
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                   434       0  100.00%
contracts/0.4.24/oracle/LegacyOracle.sol                          72       0  100.00%
contracts/0.4.24/utils/Pausable.sol                                9       0  100.00%
contracts/0.4.24/utils/Versioned.sol                               5       0  100.00%
contracts/0.6.12/WstETH.sol                                       17       0  100.00%
contracts/0.8.25/ValidatorExitDelayVerifier.sol                   64       0  100.00%
contracts/0.8.25/interfaces/IStakingRouter.sol                     0       0  100.00%
contracts/0.8.25/interfaces/IValidatorsExitBus.sol                 0       0  100.00%
contracts/0.8.4/WithdrawalsManagerProxy.sol                       61       0  100.00%
contracts/0.8.9/BeaconChainDepositor.sol                          21       2  90.48%   48, 51
contracts/0.8.9/Burner.sol                                        71       0  100.00%
contracts/0.8.9/DepositSecurityModule.sol                        128       0  100.00%
contracts/0.8.9/EIP712StETH.sol                                   16       0  100.00%
contracts/0.8.9/LidoExecutionLayerRewardsVault.sol                16       0  100.00%
contracts/0.8.9/LidoLocator.sol                                   20       0  100.00%
contracts/0.8.9/OracleDaemonConfig.sol                            28       0  100.00%
contracts/0.8.9/StakingRouter.sol                                305       0  100.00%
contracts/0.8.9/TriggerableWithdrawalsGateway.sol                 54       1  98.15%   274
contracts/0.8.9/WithdrawalQueue.sol                               88       0  100.00%
contracts/0.8.9/WithdrawalQueueBase.sol                          146       0  100.00%
contracts/0.8.9/WithdrawalQueueERC721.sol                         89       0  100.00%
contracts/0.8.9/WithdrawalVault.sol                               32       0  100.00%
contracts/0.8.9/WithdrawalVaultEIP7002.sol                        21       0  100.00%
contracts/0.8.9/lib/ExitLimitUtils.sol                            31       0  100.00%
contracts/0.8.9/lib/Math.sol                                       4       0  100.00%
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                22       0  100.00%
contracts/0.8.9/lib/UnstructuredRefStorage.sol                     2       0  100.00%
contracts/0.8.9/oracle/AccountingOracle.sol                      193       0  100.00%
contracts/0.8.9/oracle/BaseOracle.sol                             89       1  98.88%   397
contracts/0.8.9/oracle/HashConsensus.sol                         263       1  99.62%   1005
contracts/0.8.9/oracle/ValidatorsExitBus.sol                     136       1  99.26%   516
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol                53       1  98.11%   232
contracts/0.8.9/proxy/OssifiableProxy.sol                         17       0  100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      232       0  100.00%
contracts/0.8.9/utils/DummyEmptyContract.sol                       0       0  100.00%
contracts/0.8.9/utils/PausableUntil.sol                           31       0  100.00%
contracts/0.8.9/utils/Versioned.sol                               11       0  100.00%
contracts/0.8.9/utils/access/AccessControl.sol                    23       0  100.00%
contracts/0.8.9/utils/access/AccessControlEnumerable.sol           9       0  100.00%
contracts/testnets/sepolia/SepoliaDepositAdapter.sol              21      21  0.00%    49-100
TOTAL                                                           3211      28  99.13%

Diff against master

Filename                                              Stmts    Miss  Cover
--------------------------------------------------  -------  ------  --------
contracts/0.4.24/nos/NodeOperatorsRegistry.sol          -78       0  +100.00%
contracts/0.8.25/ValidatorExitDelayVerifier.sol         +64       0  +100.00%
contracts/0.8.25/interfaces/IStakingRouter.sol            0       0  +100.00%
contracts/0.8.25/interfaces/IValidatorsExitBus.sol        0       0  +100.00%
contracts/0.8.9/LidoLocator.sol                          +2       0  +100.00%
contracts/0.8.9/StakingRouter.sol                       -11       0  +100.00%
contracts/0.8.9/TriggerableWithdrawalsGateway.sol       +54      +1  +98.15%
contracts/0.8.9/WithdrawalVault.sol                     +11       0  +100.00%
contracts/0.8.9/WithdrawalVaultEIP7002.sol              +21       0  +100.00%
contracts/0.8.9/lib/ExitLimitUtils.sol                  +31       0  +100.00%
contracts/0.8.9/oracle/AccountingOracle.sol              +3      -2  +1.05%
contracts/0.8.9/oracle/ValidatorsExitBus.sol           +136      +1  +99.26%
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol      -38      -1  +0.31%
TOTAL                                                  +195      -1  +0.09%

Results for commit: 5c78974

Minimum allowed coverage is 95%

♻️ This comment has been updated with latest results

mkurayan
mkurayan reviewed Jun 24, 2025
View reviewed changes
contracts/0.8.9/oracle/AccountingOracle.sol
@@ -178,13 +179,18 @@ contract AccountingOracle is BaseOracle {
_initialize(admin, consensusContract, consensusVersion, lastProcessingRefSlot);

_updateContractVersion(2);
_updateContractVersion(3);
}

function finalizeUpgrade_v2(uint256 consensusVersion) external {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider to comment this or remove. In other contracts we usually we keep only latest finalize version.

@eddort eddort merged commit d262d81 into feat/gate-seal-tw Jun 24, 2025
9 of 10 checks passed
@eddort eddort deleted the fix/tw-ao-initialize-v3 branch June 24, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurayan mkurayan mkurayan approved these changes

@F4ever F4ever F4ever approved these changes

Assignees
No one assigned
Labels
valset Updates from the ValSet Tech team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eddort @mkurayan @F4ever
0