8000 Description to external methods & constants by Amuhar · Pull Request #1092 · lidofinance/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Description to external methods & constants #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

Description to external methods & constants #1092

merged 1 commit into from
May 21, 2025

Conversation

Amuhar
Copy link
Contributor
@Amuhar Amuhar commented May 21, 2025

No description provided.

@Amuhar Amuhar requested a review from a team as a code owner May 21, 2025 09:36
@Amuhar Amuhar merged commit 03c11c3 into feat/triggerable-exits May 21, 2025
8 of 9 checks passed
@Amuhar Amuhar deleted the fix/description branch May 21, 2025 09:37
@github-actions GitHub Actions
Copy link

badge

Hardhat Unit Tests Coverage Summary

Filename                                                       Stmts    Miss  Cover    Missing
-----------------------------------------------------------  -------  ------  -------  --------------------------------------------------
contracts/0.4.24/Lido.sol                                        212       0  100.00%
contracts/0.4.24/StETH.sol                                        72       0  100.00%
contracts/0.4.24/StETHPermit.sol                                  15       0  100.00%
contracts/0.4.24/lib/Packed64x4.sol                                5       0  100.00%
contracts/0.4.24/lib/SigningKeys.sol                              36       0  100.00%
contracts/0.4.24/lib/StakeLimitUtils.sol                          37       0  100.00%
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                   434      11  97.47%   308-310, 592-593, 621, 1154, 1335-1342, 1418, 1429
contracts/0.4.24/oracle/LegacyOracle.sol                          72       0  100.00%
contracts/0.4.24/utils/Pausable.sol                                9       0  100.00%
contracts/0.4.24/utils/Versioned.sol                               5       0  100.00%
contracts/0.6.12/WstETH.sol                                       17       0  100.00%
contracts/0.8.25/ValidatorExitDelayVerifier.sol                   68       2  97.06%   354, 389
contracts/0.8.25/interfaces/IStakingRouter.sol                     0       0  100.00%
contracts/0.8.25/interfaces/IValidatorsExitBus.sol                 0       0  100.00%
contracts/0.8.25/lib/BeaconTypes.sol                               0       0  100.00%
contracts/0.8.25/lib/GIndex.sol                                   33      15  54.55%   22, 34, 55, 63-82, 90, 111
contracts/0.8.25/lib/SSZ.sol                                      15       0  100.00%
contracts/0.8.4/WithdrawalsManagerProxy.sol                       61       0  100.00%
contracts/0.8.9/BeaconChainDepositor.sol                          21       2  90.48%   48, 51
contracts/0.8.9/Burner.sol                                        71       0  100.00%
contracts/0.8.9/DepositSecurityModule.sol                        128       0  100.00%
contracts/0.8.9/EIP712StETH.sol                                   16       0  100.00%
contracts/0.8.9/LidoExecutionLayerRewardsVault.sol                16       0  100.00%
contracts/0.8.9/LidoLocator.sol                                   20       0  100.00%
contracts/0.8.9/OracleDaemonConfig.sol                            28       0  100.00%
contracts/0.8.9/StakingRouter.sol                                314       2  99.36%   1490-1516
contracts/0.8.9/TriggerableWithdrawalsGateway.sol                 57       4  92.98%   270, 278, 284, 310
contracts/0.8.9/WithdrawalQueue.sol                               88       0  100.00%
contracts/0.8.9/WithdrawalQueueBase.sol                          146       0  100.00%
contracts/0.8.9/WithdrawalQueueERC721.sol                         89       0  100.00%
contracts/0.8.9/WithdrawalVault.sol                               27       0  100.00%
contracts/0.8.9/WithdrawalVaultEIP7685.sol                        29       3  89.66%   49-73
contracts/0.8.9/lib/ExitLimitUtils.sol                            35       0  100.00%
contracts/0.8.9/lib/Math.sol                                       4       0  100.00%
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                22       0  100.00%
contracts/0.8.9/lib/UnstructuredRefStorage.sol                     2       0  100.00%
contracts/0.8.9/oracle/AccountingOracle.sol                      190       2  98.95%   189-190
contracts/0.8.9/oracle/BaseOracle.sol                             89       1  98.88%   397
contracts/0.8.9/oracle/HashConsensus.sol                         263       1  99.62%   1005
contracts/0.8.9/oracle/ValidatorsExitBus.sol                     161      18  88.82%   270, 399-404, 420, 514, 546-560, 591, 611, 731
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol                60       2  96.67%   98, 243
contracts/0.8.9/proxy/OssifiableProxy.sol                         17       0  100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      232       0  100.00%
contracts/0.8.9/utils/DummyEmptyContract.sol                       0       0  100.00%
contracts/0.8.9/utils/PausableUntil.sol                           31       0  100.00%
contracts/0.8.9/utils/Versioned.sol                               11       0  100.00%
contracts/0.8.9/utils/access/AccessControl.sol                    23       0  100.00%
contracts/0.8.9/utils/access/AccessControlEnumerable.sol           9       0  100.00%
contracts/testnets/sepolia/SepoliaDepositAdapter.sol              21      21  0.00%    49-100
TOTAL                                                           3311      84  97.46%

Diff against master

Filename                                              Stmts    Miss  Cover
--------------------------------------------------  -------  ------  --------
contracts/0.4.24/nos/NodeOperatorsRegistry.sol          -78     +11  -2.53%
contracts/0.8.25/ValidatorExitDelayVerifier.sol         +68      +2  +97.06%
contracts/0.8.25/interfaces/IStakingRouter.sol            0       0  +100.00%
contracts/0.8.25/interfaces/IValidatorsExitBus.sol        0       0  +100.00%
contracts/0.8.25/lib/BeaconTypes.sol                      0       0  +100.00%
contracts/0.8.25/lib/GIndex.sol                         +33     +15  +54.55%
contracts/0.8.25/lib/SSZ.sol                            +15       0  +100.00%
contracts/0.8.9/LidoLocator.sol                          +2       0  +100.00%
contracts/0.8.9/StakingRouter.sol                        -2      +2  -0.64%
contracts/0.8.9/TriggerableWithdrawalsGateway.sol       +57      +4  +92.98%
contracts/0.8.9/WithdrawalVault.sol                      +6       0  +100.00%
contracts/0.8.9/WithdrawalVaultEIP7685.sol              +29      +3  +89.66%
contracts/0.8.9/lib/ExitLimitUtils.sol                  +35       0  +100.00%
contracts/0.8.9/oracle/ValidatorsExitBus.sol           +161     +18  +88.82%
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol      -31       0  -1.13%
TOTAL                                                  +295     +55  -1.58%

Results for commit: 3899a6f

Minimum allowed coverage is 95%

♻️ This comment has been updated with latest results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Amuhar
0