8000 Audit fixes by Amuhar · Pull Request #1206 · lidofinance/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Audit fixes #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 27, 2025
Merged

Audit fixes #1206

merged 4 commits into from
Jun 27, 2025

Conversation

Amuhar
Copy link
Contributor
@Amuhar Amuhar commented Jun 24, 2025

@Amuhar Amuhar requested a review from a team as a code owner June 24, 2025 19:29
@Amuhar Amuhar added the valset Updates from the ValSet Tech team label Jun 24, 2025
@Amuhar Amuhar requested a review from F4ever June 24, 2025 19:29
@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 24, 2025 •
edited
Loading

badge

Hardhat Unit Tests Coverage Summary

Filename                                                       Stmts    Miss  Cover    Missing
-----------------------------------------------------------  -------  ------  -------  ---------
contracts/0.4.24/Lido.sol                                        212       0  100.00%
contracts/0.4.24/StETH.sol                                        72       0  100.00%
contracts/0.4.24/StETHPermit.sol                                  15       0  100.00%
contracts/0.4.24/lib/Packed64x4.sol                                5       0  100.00%
contracts/0.4.24/lib/SigningKeys.sol                              36       0  100.00%
contracts/0.4.24/lib/StakeLimitUtils.sol                          37       0  100.00%
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                   434       0  100.00%
contracts/0.4.24/oracle/LegacyOracle.sol                          72       0  100.00%
contracts/0.4.24/utils/Pausable.sol                                9       0  100.00%
contracts/0.4.24/utils/Versioned.sol                               5       0  100.00%
contracts/0.6.12/WstETH.sol                                       17       0  100.00%
contracts/0.8.25/ValidatorExitDelayVerifier.sol                   64       0  100.00%
contracts/0.8.25/interfaces/IStakingRouter.sol                     0       0  100.00%
contracts/0.8.25/interfaces/IValidatorsExitBus.sol                 0       0  100.00%
contracts/0.8.4/WithdrawalsManagerProxy.sol                       61       0  100.00%
contracts/0.8.9/BeaconChainDepositor.sol                          21       2  90.48%   48, 51
contracts/0.8.9/Burner.sol                                        71       0  100.00%
contracts/0.8.9/DepositSecurityModule.sol                        128       0  100.00%
contracts/0.8.9/EIP712StETH.sol                                   16       0  100.00%
contracts/0.8.9/LidoExecutionLayerRewardsVault.sol                16       0  100.00%
contracts/0.8.9/LidoLocator.sol                                   20       0  100.00%
contracts/0.8.9/OracleDaemonConfig.sol                            28       0  100.00%
contracts/0.8.9/StakingRouter.sol                                305       0  100.00%
contracts/0.8.9/TriggerableWithdrawalsGateway.sol                 54       1  98.15%   266
contracts/0.8.9/WithdrawalQueue.sol                               88       0  100.00%
contracts/0.8.9/WithdrawalQueueBase.sol                          146       0  100.00%
contracts/0.8.9/WithdrawalQueueERC721.sol                         89       0  100.00%
contracts/0.8.9/WithdrawalVault.sol                               32       0  100.00%
contracts/0.8.9/WithdrawalVaultEIP7002.sol                        21       0  100.00%
contracts/0.8.9/lib/ExitLimitUtils.sol                            30       0  100.00%
contracts/0.8.9/lib/Math.sol                                       4       0  100.00%
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                22       0  100.00%
contracts/0.8.9/lib/UnstructuredRefStorage.sol                     2       0  100.00%
contracts/0.8.9/oracle/AccountingOracle.sol                      190       0  100.00%
contracts/0.8.9/oracle/BaseOracle.sol                             89       1  98.88%   397
contracts/0.8.9/oracle/HashConsensus.sol                         263       1  99.62%   1005
contracts/0.8.9/oracle/ValidatorsExitBus.sol                     138       1  99.28%   531
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol                52       1  98.08%   221
contracts/0.8.9/proxy/OssifiableProxy.sol                         17       0  100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      232       0  100.00%
contracts/0.8.9/utils/DummyEmptyContract.sol                       0       0  100.00%
contracts/0.8.9/utils/PausableUntil.sol                           31       0  100.00%
contracts/0.8.9/utils/Versioned.sol                               11       0  100.00%
contracts/0.8.9/utils/access/AccessControl.sol                    23       0  100.00%
contracts/0.8.9/utils/access/AccessControlEnumerable.sol           9       0  100.00%
contracts/testnets/sepolia/SepoliaDepositAdapter.sol              21      21  0.00%    49-100
TOTAL                                                           3208      28  99.13%

Diff against master

Filename                                              Stmts    Miss  Cover
--------------------------------------------------  -------  ------  --------
contracts/0.4.24/nos/NodeOperatorsRegistry.sol          -78       0  +100.00%
contracts/0.8.25/ValidatorExitDelayVerifier.sol         +64       0  +100.00%
contracts/0.8.25/interfaces/IStakingRouter.sol            0       0  +100.00%
contracts/0.8.25/interfaces/IValidatorsExitBus.sol        0       0  +100.00%
contracts/0.8.9/LidoLocator.sol                          +2       0  +100.00%
contracts/0.8.9/StakingRouter.sol                       -11       0  +100.00%
contracts/0.8.9/TriggerableWithdrawalsGateway.sol       +54      +1  +98.15%
contracts/0.8.9/WithdrawalVault.sol                     +11       0  +100.00%
contracts/0.8.9/WithdrawalVaultEIP7002.sol              +21       0  +100.00%
contracts/0.8.9/lib/ExitLimitUtils.sol                  +30       0  +100.00%
contracts/0.8.9/oracle/AccountingOracle.sol               0      -2  +1.05%
contracts/0.8.9/oracle/ValidatorsExitBus.sol           +138      +1  +99.28%
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol      -39      -1  +0.28%
TOTAL                                                  +192      -1  +0.09%

Results for commit: ff246ef

Minimum allowed coverage is 95%

♻️ This comment has been updated with latest results

@Amuhar Amuhar merged commit 2a25c7a into feat/triggerable-exits Jun 27, 2025
9 of 10 checks passed
@Amuhar Amuhar deleted the fix/orc-424-audit-fixes branch June 27, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@F4ever F4ever F4ever approved these changes

Assignees
No one assigned
Labels
valset Updates from the ValSet Tech team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amuhar @F4ever
0