Quorum/IBFT to Besu/QBFT migration #8224

pullurib · 2025-02-03T07:58:43Z

PR description

Restored the removed IBFT code required for parsing and validating IBFT extra data.
Added test cases for importing IBFT blocks into a Besu network that transitions to QBFT after the imported IBFT blocks.
Added an end-to-end test case to simulate a 5-node Besu network and validate the block import process.

Fixed Issue(s)

Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

…y fixes Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Signed-off-by: Bhanu Pulluri <59369753+pullurib@users.noreply.github.com>

Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

* Update EOFCREATE memory code Switch to longs so EOFCREATE can handle gigagas sized transactions. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

…ger#8001) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Signed-off-by: Jason Frame <jason.frame@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

…s in the release checklist (hyperledger#8004) Signed-off-by: Jason Frame <jason.frame@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

…dger#6646) Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

* 7311: spotless Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix broken BesuCommandTest Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: add class Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Move PeerTaskFeatureToggle to more appropriate location Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: add X prefix to peertask-system-enabled Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Move --Xpeertask-system-enabled out of BesuCommand and make hidden Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: spotless Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Add GetReceiptsFromPeerTask Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Move isPeerTaskSystemEnabled to SynchronizerOptions Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix javadoc issue Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix javadoc issue Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Move PeerTaskFeatureToggleTestHelper to TestUtil and fix RunnerTest Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: spotless Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Remove PeerTaskFeatureToggle in favor of including isPeerTaskSystemEnabled in SynchronizerConfiguration Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Adjust to the removal of PeerTaskFeatureToggle and use SynchronizerConfiguration to get the toggle instead Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Reduce timeout in PeerTaskRequestSender to 5s Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Refactor PeerManager to be an interface Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix up compile errors after merge Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix MetricsAcceptanceTest Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix MetricsAcceptanceTest Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix DownloadReceiptsStep when using peer task system Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Rename PeerManager to PeerSelector Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Reword PeerSelector javadoc to avoid implementation details Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Use ConcurrentHashMap in DefaultPeerSelector Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Reword trace log in DefaultPeerSelector Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Remove unused imports Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Use a 1 second delay between retries in PeerTaskExecutor to match old implementation Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Add testGetPeerButNoPeerMatchesFilter to DefaultPeerSelectorTest Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Add testGetPeerButNoPeerMatchesFilter to DefaultPeerSelectorTest Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: spotless Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix MetricsAcceptanceTest Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix MetricsAcceptanceTest Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Modify PeerTaskExecutor metric to include response time from peer Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Use SubProtocol instead of subprotocol name string in PeerTask Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: rename timing context to ignored to prevent intellij warnings Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Use constants for number of retries Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Convert PeerTaskExecutorResult to a record Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Rename PeerTaskBehavior to PeerTaskRetryBehavior Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Move peer selection logic to PeerSelector Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: spotless Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix up everything broken after merge Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Attempt to improve performance of peer task system in pipeline Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: fix compile check Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix broken workflow Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Reduce logging in JsonRpcExecutor to trace level Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: More changes in DownloadReceiptsStep Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Rework DownloadReceiptsStep Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Make changes as discussed in walkthrough meeting Remove DefaultPeerSelector, make EthPeers implement PeerSelector interface, and add PeerTask.getPeerRequirementFilter Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Update after merge and make discussed changes from walkthrough discussion Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Change to regular HashMap Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Remove runtime exception again Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Rename getPeerTaskBehavior to getPeerTaskRetryBehavior Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Rename getPeerTaskBehavior to getPeerTaskRetryBehavior Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Rework PeerTaskExecutor retry system to be 0-based Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix up compile errors after merge Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix broken DownloadReceiptsStepTest test Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Move GetReceipts to services worker for parallelism Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Refactor peer task system usage in DownloadReceiptsStep to better match old system Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Remove unused async methods in PeerTaskExecutor Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Return Optional<EthPeer> in PeerSelector.getPeer and utilise existing peer selection behavior in EthPeers Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Update after merge Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Redo getPeer again to include hasAvailableRequestCapacity check Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Add protocol spec supplier to GetReceiptsFromPeerTask Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Rework getPeer again to use LEAST_TO_MOST_BUSY comparator Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Import PeerNotConnected class instead of using fully qualified class name Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Change to specifying retry counts in PeerTask instead of behavior enums Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: clean up after merge Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: clean up after merge Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix up javadoc Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Add additional metrics to PeerTaskExecutor Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Add Predicate to PeerTask to check for partial success Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix incorrect name on isPartialSuccessTest Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Implement isPartialSuccess and add unit tests Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Add partialSuccessCounter and inflightRequestGauge in PeerTaskExecutor Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Also filter by whether a peer is fully validated Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Remove unneeded throws in RunnerTest Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix up inflight requests gauge in PeerTaskExecutor Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Update plugin api hash Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Update plugin api hash Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Add javadoc to LabelledGauge.isLabelsObserved Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Update plugin-api hash Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Update changelog Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Implement GetHeadersFromPeerTask and use in DetermineCommonAncestorTask Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Handle headers with no receipts as a special case in DownloadReceiptsStep Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Complete merge Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Get DetermineCommonAncestorTask working with peer task system Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Use taskName instead of className for labelNames Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Use snake_case for metric names Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Use _total metric name suffix Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: rework partial success handling Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Update GetReceiptsFromPeerTask with partialSuccess changes Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Update GetHeadersFromPeerTask with partialSuccess changes Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Add default implementation to LabelledGauge.isLabelsObserved Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Use Peer task systems GetHeadersFromPeerTask in GetBlockFromPeerTask Signed-off-by: Matilda Clerke 10000 <matilda.clerke@consensys.net> * 7311: Fix broken unit test Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Remove unused constructor from AbstractPeerBlockValidator Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Use GetHeadersFromPeerTask in AbstractPeerBlockValidator Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Use peer task executor in SyncTargetManager Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix javadoc on BesuControllerBuilder Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Remove logs used to confirm operation Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Implement GetHeadersFromPeerTask in FastSyncActions and PivotBlockConfirmer Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Rename parseResponse to processResponse Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Wrap peer task system usage in ethScheduler call to match other usages Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: apply spotless Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Move check for empty trie hash into GetReceiptsFromPeerTask and update unit test to test for this functionality Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: spotless Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix compile issue after merge Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix compile issue after merge Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Remove BodyValidator and update code and test to match Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Implement GetHeadersForPeerTask usage in DownloadHeadersStep Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: spotless Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: remove unneeded logs Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: spotless Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix up pre-fill and add test to test failure scenario Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Use ProtocolSchedule.anyMatch to find if any ProtocolSpecs are PoS, remove new usages of currentProtocolSpecSupplier Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Only attempt to remove headers on successful requests Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: clean up after merge Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: clean up after merge Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Use peer task system in RangeHeadersFetcher Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Use peer task system in DownloadHeaderSequenceTask Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix GetHeadersFromPeerTask mocking in CheckPointSyncChainDownloaderTest Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Extract peer task executor answer for getHeaders to separate class for reuse in tests Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: spotless Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Implement peer task system usage in BackwardSyncStep Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Implement peer task system usage in ChainHeadTracker Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Implement peer task system usage in PivotSelectorFromSafeBlock and improve logging Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Implement unit test for GetHeadersFromPeerTask Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix up merge compile error Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Ensure FastSyncActions and PivotSelectorFromSafeBlock retry getting headers for all peers, matching RetryingGetHeaderFromPeerByHashTask Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Change PeerTaskExecutorResult.ethPeer to an Optional Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Use CancellationException instead of InterruptedException in PivotBlockConfirmer Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Use PivotBlockRetriever.MAX_QUERY_RETRIES_PER_PEER to set retries for GetHeadersFromPeerTask Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: spotless Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Add PeerTask.shouldDisconnectPeer and ensure functionality matches old code Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Remove old info logs Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix broken test by correctly including peer in PeerTaskExecutorResults in test classes Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix incorrect equality tests Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix broken test Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: spotless Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Move PeerTaskExecutor into EthContext to reduce plumbing changes Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: spotless Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Remove protocol check from GetHeadersFromPeerTask.getPeerRequirementFilter Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix broken test Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix broken integration test Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Refactor peer task validation Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Refactor peer task validation Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Use peer count for retry count when getting headers in BackwardSyncStep, FastSyncActions, and PivotSelectorFromSafeBlock Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: spotless Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Move chainstate update into GetHeadersFromPeerTask.postProcessResult Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Fix compile errors Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7311: Update after merge Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> --------- Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

* Improve equals performance operation on Address * Use toArrayUnsafe instead of toArray to reduce GC overhead Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

…7838) * Fix incorrect duration for THREE_MINUTES from 1 minute to 3 minutes Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Round change upon f+1 RC messages (experimental option) Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Update besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java Co-authored-by: Matt Whitehead <matthew1001@hotmail.com> Signed-off-by: Bhanu Pulluri <59369753+pullurib@users.noreply.github.com> * revert an unrelated fix already merged to main Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * update return value description Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * fix logging level for couple of logs Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Review changes , added tests Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Merge and fix controller builder test context Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * minor fix to import missing class after merging main Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Add missing function header comments Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> --------- Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> Signed-off-by: Bhanu Pulluri <59369753+pullurib@users.noreply.github.com> Co-authored-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> Co-authored-by: Matt Whitehead <matthew1001@hotmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Jason Frame <jason.frame@consensys.net> Co-authored-by: Matt Whitehead <matthew.whitehead@kaleido.io> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

* add newline to beginning of PR template Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * fix initial typo Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * fix tx typos Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

…yperledger#8166) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

…wal (hyperledger#7988) * 7582: Add naive RLP caching for BlockHeader, Transaction, and Withdrawal Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7582: spotless Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7582: Fix broken test after merge Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7582: Back out withdrawal changes Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7582: Fix up compile error after merge Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7582: Apply naive RLP caching in transaction encoder/decoder classes Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 8053: Add RLPDecodingHelpers.Kind.EM and handle empty lists in AbstractRLPInput Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7582: Add trace logging to AbstractRLPInput Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Revert previous change, implement new fix Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Revert previous change, implement new fix Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7582: Finish applying naive RLP caching to transaction encoder/decoder classes Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Remove unused LOG Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7582: Make explicit the expectation that RLP.validate does not throw an exception in test Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7582: SPOTLESS Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7582: Remove redundant curly braces Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7582: Remove Optional from rawRlp in Transaction.Builder Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7582: Make new BlockHeader constructor private Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Refactor tranaction encoder classes Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Remove logging changes from RLP module Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * spotless Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> --------- Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net> Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

…r#8212) In CodeDelegation.authorizer(), return empty to skip code delegation processing if recId outside native lib's bounds --------- Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

…ledger#8221) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

…t selected (hyperledger#8216) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

* Stop all sub processes spawn by acceptance tests Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Split long running test in 3 parts Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Run ATs sequentially Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> --------- Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

…r#8236) This reverts commit d691f45. Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Signed-off-by: Jason Frame <jason.frame@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

…rledger#8223) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Supports Pectra EIP-7691 Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

…ledger#8231) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

…r#7963) (hyperledger#8140) Signed-off-by: philosup <philosup@gmail.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

…8235) Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

* update rpc gas cap default to 50M Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

…erledger#8243) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

…er#8254) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Signed-off-by: Jason Frame <jason.frame@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

- Prague newPayload validation fixes - Testing the unsupported fork timestamp cases Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

pullurib · 2025-02-06T23:47:29Z

Discarding in lieu of #8262

Bhanu Pulluri added 12 commits December 17, 2024 18:22

Initial commit with legacy IBFT files

ee8945d

Merge branch 'main' into quorum-qbft-sync

0db1923

changes to match block hash

07d683f

Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

add testcase for migration using block import

21640e0

Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

IBFT legacy cleanup based on few review comments

304446c

Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Add back header validations

b4857a3

Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Add missing comments and review changes

0eab2de

Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

remove unused ibft1 config options

0fae5da

Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

cleanup

4dd580f

Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Use tempdirs in testcase

844f49e

Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

remove IBFT encode

ad0adb3

Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Increase waitfor timeout and revert an unintended change

d94316b

Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

pullurib marked this pull request as draft February 3, 2025 07:58

matthew1001 mentioned this pull request Feb 3, 2025

Propose Bhanu Pulluri as a maintainer #8230

Merged

Fix vote tally checking at transition

9579639

Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

pullurib marked this pull request as ready for review February 4, 2025 13:45

Bhanu Pulluri and others added 14 commits February 5, 2025 22:25

Fix sync event subscription in mining coordinator and couple votetall…

35704e0

…y fixes Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Merge branch 'main' into quorum-qbft-sync

65f1a71

Signed-off-by: Bhanu Pulluri <59369753+pullurib@users.noreply.github.com>

Initial commit with legacy IBFT files

64ece63

Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Allow frontier simulation when Base Fee is present (hyperledger#7965)

566bf7a

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Support rpc pending block tag when estimating gas (hyperledger#7951)

ea6b201

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Update EOFCREATE memory code (hyperledger#7979)

d642674

* Update EOFCREATE memory code Switch to longs so EOFCREATE can handle gigagas sized transactions. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

account overrides: parse hex string into nonce long (hyperledger#7999)

ab8d948

Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Small refactoring - Move UnsignedLongParameter to datatypes (hyperled…

8d103c0

…ger#8001) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Update changelog for 24.12.0-RC2 (hyperledger#8002)

5a8dd47

Signed-off-by: Jason Frame <jason.frame@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Include mention of 24 hours notice for confirmation of outstanding PR…

ee9b4c0

…s in the release checklist (hyperledger#8004) Signed-off-by: Jason Frame <jason.frame@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Use unsigned long parameter (hyperledger#8003)

1cc2f7e

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Retrieve all transaction receipts for a block in one request (hyperle…

80819e9

…dger#6646) Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

pullurib and others added 27 commits February 5, 2025 23:09

Init KZG precompile contract before importing blocks (hyperledger#8219)

d8a1482

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Simulation: Add state to StateOverride (eth_call, eth_simulateV1). (h…

55caa94

…yperledger#8166) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Treat timestamp as unsigned long in engine api fork validation (hyper…

5135f75

…ledger#8221) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Add a tx selector to skip txs from the same sender after the first no…

f988b9e

…t selected (hyperledger#8216) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Fix the simulation of txs with future nonce (hyperledger#8215)

88a871c

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

disable flaky test classes (hyperledger#8239)

d779b89

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Revert "Stop all sub processes spawn by acceptance tests" (hyperledge…

ee9438c

…r#8236) This reverts commit d691f45. Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Qbft block type (hyperledger#8142)

3426dd7

Signed-off-by: Jason Frame <jason.frame@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Invalidate engine_newPayloadV3 if it contains executionRequests (hype…

502145f

…rledger#8223) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Use 9 for max blobs when sizing BlobCache (hyperledger#8222)

1c013a8

Supports Pectra EIP-7691 Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

[TESTING] disable flaky fast sync actions test (hyperledger#8208)

bfb5ba3

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Not all invalid transient not selected txs should be penalized (hyper…

c21caf7

…ledger#8231) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

add Xchain-pruning-blocks-retained must be >= epochlength (hyperledge…

ae6f4f5

…r#7963) (hyperledger#8140) Signed-off-by: philosup <philosup@gmail.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Add transaction hash for debug trace responses (hyperledger#8205)

721e00f

Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

[CHANGELOG] add upcoming breaking changes to unreleased (hyperledger#…

f673d2e

…8235) Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

update rpc gas cap default to 50M (hyperledger#8251)

6e83e67

* update rpc gas cap default to 50M Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

EIP2935 - Use system call instead of direct storage modification (hyp…

6e24d2d

…erledger#8243) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Use PendingTransaction interface in block creation classes (hyperledg…

34e64f1

…er#8254) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Remove PostMergeContext singleton (hyperledger#8253)

fe21426

Signed-off-by: Jason Frame <jason.frame@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Prague times for holesky and sepolia (hyperledger#8255)

31a04b7

Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

Prague Engine API validation fixes (hyperledger#8250)

2a9b4d1

- Prague newPayload validation fixes - Testing the unsupported fork timestamp cases Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

merge main

5c6a5c7

pullurib marked this pull request as draft February 6, 2025 04:20

pullurib closed this Feb 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Quorum/IBFT to Besu/QBFT migration #8224

Quorum/IBFT to Besu/QBFT migration #8224

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Quorum/IBFT to Besu/QBFT migration #8224

Quorum/IBFT to Besu/QBFT migration #8224

Uh oh!

Conversation

PR description

Fixed Issue(s)

Uh oh!

Uh oh!

Uh oh!