8000 Revert "Stop all sub processes spawn by acceptance tests" by macfarla · Pull Request #8236 · hyperledger/besu · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert "Stop all sub processes spawn by acceptance tests" #8236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 4, 2025
Merged

Revert "Stop all sub processes spawn by acceptance tests" #8236

merged 2 commits into from
Feb 4, 2025

Conversation

macfarla
Copy link
Contributor
@macfarla macfarla commented Feb 4, 2025

Reverts #8226

This seems to have caused other issues with ATs

On one run, ATs failed with daemon exiting unexpectedly.
Sally reran the failed tests. One runner showed "skipped" status, didn't seem to complete
https://github.com/hyperledger/besu/actions/runs/13125472741/job/36622936240?pr=8222
The hosted runner encountered an error while running your job. (Error Type: Disconnect).

Simon reran, failed after taking 39+ minutes
https://github.com/hyperledger/besu/actions/runs/13125472741/job/36625756042?pr=8222

FAILURE: Build failed with an exception.

* What went wrong:
Gradle build daemon disappeared unexpectedly (it may have been killed or may have crashed)

Daemon pid: 2236
  log file: /home/runner/.gradle/daemon/8.8/daemon-2236.out.log
----- Last  20 lines from daemon log file - daemon-2236.out.log -----
2025-02-04T02:44:13.763+0000 [DEBUG] [org.gradle.launcher.daemon.server.DefaultDaemonConnection] thread 201: Received non-IO message from client: Build{id=51e08b5d-71e9-4b25-a4bd-df50163e2dce, currentDir=/home/runner/work/besu/besu}
2025-02-04T02:44:13.764+0000 [INFO] [org.gradle.launcher.daemon.server.DefaultIncomingConnectionHandler] Received command: Build{id=51e08b5d-71e9-4b25-a4bd-df50163e2dce, currentDir=/home/runner/work/besu/besu}.
2025-02-04T02:44:13.764+0000 [DEBUG] [org.gradle.launcher.daemon.server.DefaultIncomingConnectionHandler] Starting executing command: Build{id=51e08b5d-71e9-4b25-a4bd-df50163e2dce, currentDir=/home/runner/work/besu/besu} with connection: socket connection from /127.0.0.1:40641 to /127.0.0.1:33992.
2025-02-04T02:44:13.764+0000 [DEBUG] [org.gradle.launcher.daemon.server.DaemonStateCoordinator] Command execution: started DaemonCommandExecution[command = Build{id=51e08b5d-71e9-4b25-a4bd-df50163e2dce, currentDir=/home/runner/work/besu/besu}, connection = DefaultDaemonConnection: socket connection from /127.0.0.1:40641 to /127.0.0.1:33992] after 0.0 minutes of idle

8000
@macfarla
Revert "Stop all sub processes spawn by acceptance tests (#8226)"
86a9d51 
This reverts commit d691f45.

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla force-pushed the revert-8226-stop-besu-subprocess-in-ats branch from e5efec6 to 86a9d51 Compare February 4, 2025 03:16
@macfarla macfarla merged commit 5534d65 into main Feb 4, 2025
43 checks passed
@macfarla macfarla deleted the revert-8226-stop-besu-subprocess-in-ats branch February 4, 2025 05:00
@fab-10
Copy link
Contributor
fab-10 commented Feb 4, 2025

The list of ATs that were running on that runner

 --tests org.hyperledger.besu.tests.acceptance.jsonrpc.JsonRpcWebsocketAuthenticationAcceptanceTest --tests org.hyperledger.besu.tests.acceptance.plugins.RpcEndpointServicePluginTest --tests org.hyperledger.besu.tests.acceptance.jsonrpc.admin.AdminAddPeerAcceptanceTest --tests org.hyperledger.besu.tests.acceptance.clique.CliqueZeroValidatorsAcceptanceTest --tests org.hyperledger.besu.tests.acceptance.bootstrap.ClusterNoDiscoveryAcceptanceTest --tests org.hyperledger.besu.tests.acceptance.jsonrpc.ExecutionEngineShanghaiAcceptanceTest --tests org.hyperledger.besu.tests.acceptance.jsonrpc.ExecutionEngineParisAcceptanceTest

pullurib pushed a commit to pullurib/besu that referenced this pull request Feb 6, 2025
@macfarla
Revert "Stop all sub processes spawn by acceptance tests" (hyperledge…
ee9438c 
…r#8236)

This reverts commit d691f45.

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
This was referenced Feb 12, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jframe jframe jframe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macfarla @fab-10 @jframe
0