Use PendingTransaction interface in block creation classes #8254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
c46518b to
08a62f0
Compare
garyschulte
approved these changes
Feb 5, 2025
| @@ -44,7 +43,9 @@ public TransactionEvaluationContext( | |||
| } | |||
|
|
|||
| public Transaction getTransaction() { | |||
| return pendingTransaction.getTransaction(); | |||
| // ToDo: can we avoid this cast? either by always using the interface | |||
| // or moving our Transaction implementation in the datatypes package | |||
There was a problem hiding this comment.
seems ok to cast for now, but I like the notion of always using the interface long term. hopefully this doesn't just move the class cast exception into the plugin implementation
There was a problem hiding this comment.
the plugins need to use Besu internal Transaction implementation, using the interface is a big change, but I think we should do it at some point
pullurib
pushed a commit
to pullurib/besu
that referenced
this pull request
Feb 6, 2025
…er#8254) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR is a prerequisite for letting plugins propose pending transaction during block creation, it removes the assumption that during block creation all pending transactions are of our internal type
org.hyperledger.besu.ethereum.eth.transactions.PendingTransactionusing thePendingTransactioninterface instead.No functional changes introduced by this PR.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests