Round change upon f+1 RC messages (experimental option) #7838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 17, 2024 14:45
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
matthew1001
approved these changes
Dec 2, 2024
consensus/common/src/main/java/org/hyperledger/besu/consensus/common/bft/BftHelpers.java
Outdated
Show resolved
Hide resolved
...sts/tests/src/test/java/org/hyperledger/besu/tests/acceptance/bftsoak/BftMiningSoakTest.java
Outdated
Show resolved
Hide resolved
|
I forgot about this, just having a look now. Hopefully won't take me log to get through it. |
Co-authored-by: Matt Whitehead <matthew1001@hotmail.com> Signed-off-by: Bhanu Pulluri <59369753+pullurib@users.noreply.github.com>
083956e to
468e194
Compare
added 3 commits
December 3, 2024 15:43
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
jframe
reviewed
Dec 4, 2024
consensus/common/src/main/java/org/hyperledger/besu/consensus/common/bft/BftHelpers.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/org/hyperledger/besu/consensus/qbft/statemachine/QbftBlockHeightManager.java
Outdated
Show resolved
Hide resolved
...ain/java/org/hyperledger/besu/consensus/qbft/statemachine/QbftBlockHeightManagerFactory.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
jframe
approved these changes
Dec 17, 2024
|
@pullurib compile errors |
|
This pr is stale because it has been open for 30 days with no activity. |
|
@pullurib are you working on this PR yet? |
|
Yes, @Gabriel-Trintinalia , I'm back to working on it now. |
added 3 commits
January 23, 2025 01:23
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
|
@macfarla all local tests pass . Didn't run into any compile errors. Could you trigger the tests again. Thanks Update: Nevermind, I'm able to repro error now. Will fix and update |
added 2 commits
January 27, 2025 12:31
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
|
Fixed the compile errors - all of them are adding comments, missing params for function headers. Build and local tests run fine now . |
pullurib
added a commit
to pullurib/besu
that referenced
this pull request
Feb 6, 2025
…7838) * Fix incorrect duration for THREE_MINUTES from 1 minute to 3 minutes Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Round change upon f+1 RC messages (experimental option) Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Update besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java Co-authored-by: Matt Whitehead <matthew1001@hotmail.com> Signed-off-by: Bhanu Pulluri <59369753+pullurib@users.noreply.github.com> * revert an unrelated fix already merged to main Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * update return value description Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * fix logging level for couple of logs Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Review changes , added tests Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Merge and fix controller builder test context Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * minor fix to import missing class after merging main Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Add missing function header comments Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> --------- Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> Signed-off-by: Bhanu Pulluri <59369753+pullurib@users.noreply.github.com> Co-authored-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> Co-authored-by: Matt Whitehead <matthew1001@hotmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Jason Frame <jason.frame@consensys.net> Co-authored-by: Matt Whitehead <matthew.whitehead@kaleido.io> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Plan going ahead
Next release
--Xqbft-enable-early-round-change = false
--Xqbft-enable-early-round-change = true
Besu release once feature has been proven stable:
Remove --Xqbft-enable-early-round-change (NOT make it --qbft-enable-early-round-change)
Fixed Issue(s)
#1822