Add field test for Digest article list design #20912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maestromac
approved these changes
May 1, 2024
|
Uffizzi Preview |
5 tasks
benhalpern
added a commit
that referenced
this pull request
May 3, 2024
* Add field test for Digest article list design * Add check for cached user
benhalpern
added a commit
that referenced
this pull request
May 6, 2024
* Add proper frontend for Algolia search * Update app/models/concerns/algolia_searchable/searchable_comment.rb Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update app/models/concerns/algolia_searchable/searchable_article.rb Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix formatting * Fix: copy to clipboard message (#20898) * fix: copy to clipboard message * chore: deletion of unused imports * Pick winner in header field test (#20911) * Updated the twitter icon to X icon - solved icon issue #20356 (#20910) * changed the twitter icon to X icon in assets/images/twitter.svg * Changed the twitter icon to X in assets/images/twitter.svg * Add field test for Digest article list design (#20912) * Add field test for Digest article list design * Add check for cached user * Include cached user in select (#20913) * Include cached user in select * Add tags * update style for new follower email (#20908) * Fix #19037 (#20917) * Add alternate returns for html * Remove console log --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Iasmim Pereira <100351576+IasmimCristina@users.noreply.github.com> Co-authored-by: Darshan Padia <darshanpadia5@gmail.com> Co-authored-by: Philip How <philip.j.how@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
New field test to add new elements to the list (user name/image, and/or tags) and to see if a bordered card is more effective than plain.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings