8000 Add field test for Digest article list design by benhalpern · Pull Request #20912 · forem/forem · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add field test for Digest article list design #20912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2024
Merged

Add field test for Digest article list design #20912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
786ee19
Add field test for Digest article list design
benhalpern May 1, 2024
549c112
Add check for cached user
benhalpern May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/mailers/digest_mailer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ def digest_email
@billboards = params[:billboards]
@unsubscribe = generate_unsubscribe_token(@user.id, :email_digest_periodic)

@article_design_variant = field_test(:digest_articles_design_05_02, participant: @user)
subject = generate_title

# set sendgrid category in the header using smtp api
Expand Down
80 changes: 68 additions & 12 deletions app/views/mailers/digest_mailer/digest_email.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@
</tr>
<tr>
<td bgcolor="#F8F8F8" style="padding: 14px; text-align: center; color: #3a3c3d; font-size: 16px;border-radius: 12px; border: 3px solid <%= Settings::UserExperience.primary_brand_color_hex %>; font-weight: bold;">
👋 Hey <%= @user.name.split(" ").first %>, let's get you <span style="display:inline-block">caught up!</span>
👋 Hey <%= @user.name.split.first %>, let's get you <span style="display:inline-block">caught up!</span>
</td>
</tr>

<% if @billboards&.first&.present? %>
<tr>
<td bgcolor="#FFFFFF" style="padding: 16px 0 4px;">
<hr style="border-top: 3px solid #0a0a0a;"/>
<hr style="border-top: 3px solid #0a0a0a;" />
</td>
</tr>
<tr>
Expand All @@ -27,18 +27,74 @@
</tr>
<tr>
<td bgcolor="#FFFFFF" style="padding: 12px 0 8px;">
<hr style="border-top: 3px solid #0a0a0a;"/>
<hr style="border-top: 3px solid #0a0a0a;" />
</td>
</tr>
<% end %>
<!-- Articles List -->
<% @articles.each_with_index do |article, i| %>
<tr>
<td bgcolor="#FFFFFF" style="padding: <%= i == 0 ? "27" : "17" %>px 2px 0px; text-align: left;">
<a href="<%= article_url(article) %>?context=digest" style="font-weight: bold; color:#0a0a0a; font-size: 16px;display:block;"><%= article.title.strip %></a>
<p style="margin-top: 5px; font-size: 14px; color: #808080;">
<%= truncate(article.description, length: 180) %>
</p>
<td bgcolor="#FFFFFF" style="padding: <%= i.zero? ? "27" : "17" %>px 2px 0px; text-align: left;">
<% case @article_design_variant %>
<% when "base" %>
<a href="<%= article_url(article) %>?context=digest" style="font-weight: bold; color:#0a0a0a; font-size: 16px;display:block;"><%= article.title.strip %></a>
<p style="margin-top: 5px; font-size: 14px; color: #808080;">
<%= truncate(article.description, length: 180) %>
</p>
<% when "base_with_user" %>
<a href="<%= article_url(article) %>?context=digest" style="font-weight: bold; color:#0a0a0a; font-size: 16px;display:block;"><%= article.title.strip %></a>
<% if article.cached_user.present? %>
<p style="margin-top: 8px;margin-bottom: 3px; font-size: 14px; color: #6b6b6b;font-weight:700;margin-left:-2px;">
<img alt="<%= article.cached_user.name %> logo" src="<%= article.cached_user.profile_image_90 %>" style="height:18px;width:18px;border-radius:100px;vertical-align:-4px;border:1px solid #808080;" loading="lazy" />
<%= article.cached_user.name %>
</p>
<% end %>
<p style="margin-top: 5px; font-size: 14px; color: #808080;">
<%= truncate(article.description, length: 180) %>
</p>
<% when "base_with_tags" %>
<a href="<%= article_url(article) %>?context=digest" style="font-weight: bold; color:#0a0a0a; font-size: 16px;display:block;"><%= article.title.strip %></a>
<p style="margin-top: 6px;margin-bottom: 6px; font-size: 13px; color: #6b6b6b;">
<% article.decorate.cached_tag_list_array.each do |tag| %>
<span style="display:inline-block;background:#e6e6e6;border: 1px solid #dedede;border-radius:3px;padding:1px 4px;margin-right:3px;">#<%= tag %></span>
<% end %>
</p>
<p style="margin-top: 5px; font-size: 14px; color: #808080;">
<%= truncate(article.description, length: 180) %>
</p>
<% when "border" %>
<div style="border:2px solid #0a0a0a;border-radius:12px;padding:12px 12px 3px;">
<a href="<%= article_url(article) %>?context=digest" style="font-weight: bold; color:#0a0a0a; font-size: 16px;display:block;"><%= article.title.strip %></a>
<p style="margin-top: 5px; font-size: 14px; color: #808080;">
<%= truncate(article.description, length: 180) %>
</p>
</div>
<% when "border_with_user" %>
<div style="border:2px solid #0a0a0a;border-radius:12px;padding:12px 12px 3px;">
<a href="<%= article_url(article) %>?context=digest" style="font-weight: bold; color:#0a0a0a; font-size: 16px;display:block;"><%= article.title.strip %></a>
<% if article.cached_user.present? %>
<p style="margin-top: 8px;margin-bottom: 3px; font-size: 14px; color: #6b6b6b;font-weight:700;margin-left:-2px;">
<img alt="<%= article.cached_user.name %> logo" src="<%= article.cached_user.profile_image_90 %>" style="height:18px;width:18px;border-radius:100px;vertical-align:-4px;border:1px solid #808080;" loading="lazy" />
<%= article.cached_user.name %>
</p>
<% end %>
<p style="margin-top: 5px; font-size: 14px; color: #808080;">
<%= truncate(article.description, length: 180) %>
</p>
</div>
<% when "border_with_tags" %>
<div style="border:2px solid #0a0a0a;border-radius:12px;padding:12px 12px 3px;">
<a href="<%= article_url(article) %>?context=digest" style="font-weight: bold; color:#0a0a0a; font-size: 16px;display:block;"><%= article.title.strip %></a>
<p style="margin-top: 6px;margin-bottom: 6px; font-size: 13px; color: #6b6b6b;">
<% article.decorate.cached_tag_list_array.each do |tag| %>
<span style="display:inline-block;background:#e6e6e6;border: 1px solid #dedede;border-radius:3px;padding:1px 4px;margin-right:3px;">#<%= tag %></span>
<% end %>
</p>
<p style="margin-top: 5px; font-size: 14px; color: #808080;">
<%= truncate(article.description, length: 180) %>
</p>
</div>
<% end %>
</td>
</tr>
<% end %>
Expand All @@ -53,7 +109,7 @@
<% end %>
<tr>
<td bgcolor="#FFFFFF" style="padding: 20px 0;">
<hr style="border-top: 3px solid #0a0a0a;"/>
<hr style="border-top: 3px solid #0a0a0a;" />
</td>
</tr>

Expand All @@ -65,7 +121,7 @@
</tr>
<tr>
<td bgcolor="#FFFFFF" style="padding: 12px 0 8px;">
<hr style="border-top: 3px solid #0a0a0a;"/>
<hr style="border-top: 3px solid #0a0a0a;" />
</td>
</tr>

Expand All @@ -87,10 +143,10 @@

<tr>
<td bgcolor="#FFFFFF" style="padding: 10px 0;">
<hr style="border-top: 3px solid #0a0a0a;"/>
<hr style="border-top: 3px solid #0a0a0a;" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</table>
21 changes: 21 additions & 0 deletions config/field_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,27 @@
################################################################################
################################################################################
experiments:
digest_articles_design_05_02:
started_at: 2024-05-02
variants:
- base
- base_with_user
- base_with_tags
- border
- border_with_user
- border_with_tags
weights:
- 20
- 16
- 16
- 16
- 16
- 16
goals:
- user_creates_pageview
- user_creates_article_reaction
- user_views_pages_on_at_least_two_different_days_within_a_week
- user_views_pages_on_at_least_four_different_days_within_a_week
digest_headers_04_22:
started_at: 2024-04-22
ended_at: 2024-05-01
Expand Down
0