Implement MVP frontend for Algolia search #20909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Uffizzi Ephemeral Environment Deploying☁️ https://app.uffizzi.com/github.com/forem/forem/pull/20909 ⚙️ Updating now by workflow run 8941084185. What is Uffizzi? Learn more! |
* fix: copy to clipboard message * chore: deletion of unused imports
* Add field test for Digest article list design * Add check for cached user
* Include cached user in select * Add tags
maestromac
reviewed
May 6, 2024
| end | ||
|
|
||
| add_attribute(:profile_image) { { url: profile_image_90 } } | ||
| # add_attribute(:profile_image_90) { profile_image_90 } |
There was a problem hiding this comment.
nit: seeing that other searchable also had this enabled, should this be uncommented?
maestromac
approved these changes
May 6, 2024
|
Yeah @maestromac there are some interface inconsistencies in our use here which should be ironed out if possible. We're now in position to make final quality tweaks before ultimately going live. |
This was referenced May 8, 2024
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This should finish a basic implementation of Algolia search on Forem to provide an augmentation to the basic Postgres search for faster and more relevant results in the right cases.
As noted, PG is still the default and appropriate for smaller instances, and we could add other search indexes later.
We will also in the future make use of more Algolia features.
This implementation will likely require some fast follow to tune result relevancy in production, but should provide a basic upgrade.
Related Tickets & Documents