8000 Update style for new follower email by PhilipHow · Pull Request #20908 · forem/forem · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update style for new follower email #20908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

PhilipHow
Copy link
Contributor
@PhilipHow PhilipHow commented May 1, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

  • A new style for the new follower email.
  • I've made the new header a partial for re-use in other email templates

QA Instructions, Screenshots, Recordings

image

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: only frontend changes
  • I need help with writing tests

Copy link
Contributor
github-actions bot commented May 1, 2024

Uffizzi Ephemeral Environment Deploying

☁️ https://app.uffizzi.com/github.com/forem/forem/pull/20908

⚙️ Updating now by workflow run 8910076223.

What is Uffizzi? Learn more!

@PhilipHow PhilipHow marked this pull request as ready for review May 1, 2024 15:59
@PhilipHow PhilipHow requested a review from a team as a code owner May 1, 2024 15:59
@PhilipHow PhilipHow requested review from lightalloy, maestromac and benhalpern and removed request for a team and lightalloy May 1, 2024 15:59
Copy link
Contributor
@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@benhalpern benhalpern added this pull request to the merge queue May 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 1, 2024
@benhalpern benhalpern added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit 7c3e5b2 May 2, 2024
@benhalpern benhalpern deleted the phil/update-new-follower-email branch May 2, 2024 13:48
benhalpern pushed a commit that referenced this pull request May 3, 2024
benhalpern added a commit that referenced this pull request May 6, 2024
* Add proper frontend for Algolia search

* Update app/models/concerns/algolia_searchable/searchable_comment.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update app/models/concerns/algolia_searchable/searchable_article.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix formatting

* Fix: copy to clipboard message (#20898)

* fix: copy to clipboard message

* chore: deletion of unused imports

* Pick winner in header field test (#20911)

* Updated the twitter icon to X icon - solved icon issue #20356  (#20910)

* changed the twitter icon to X icon in assets/images/twitter.svg

* Changed the twitter icon to X in assets/images/twitter.svg

* Add field test for Digest article list design (#20912)

* Add field test for Digest article list design

* Add check for cached user

* Include cached user in select (#20913)

* Include cached user in select

* Add tags

* update style for new follower email (#20908)

* Fix #19037 (#20917)

* Add alternate returns for html

* Remove console log

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Iasmim Pereira <100351576+IasmimCristina@users.noreply.github.com>
Co-authored-by: Darshan Padia <darshanpadia5@gmail.com>
Co-authored-by: Philip How <philip.j.how@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0