8000 feat: support `.editorconfig-checker.json` config by theoludwig · Pull Request #375 · editorconfig-checker/editorconfig-checker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: support .editorconfig-checker.json config #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 9, 2024
Merged

feat: support .editorconfig-checker.json config #375

merged 5 commits into from
Sep 9, 2024

Conversation

theoludwig
Copy link
Member
@theoludwig theoludwig commented Sep 8, 2024 •
edited
Loading

Fixes #306

8000
@theoludwig theoludwig added this to the v3.1.0 milestone Sep 8, 2024
@theoludwig theoludwig self-assigned this Sep 8, 2024
@theoludwig theoludwig requested a review from ccoVeille September 8, 2024 12:01
@theoludwig
Copy link
Member Author

Feel free to review also @klaernie 😄

@theoludwig theoludwig force-pushed the feat/config-filenames-default branch from 07928ce to 5e7133f Compare September 8, 2024 12:03
theoludwig
theoludwig commented Sep 8, 2024
View reviewed changes
@theoludwig theoludwig changed the title feat: add more config file names: .ecrc.json, .editorconfig-checkerrc, .editorconfig-checkerrc.json feat: add more config file names by default Sep 8, 2024
theoludwig
theoludwig commented Sep 8, 2024
View reviewed changes
@theoludwig theoludwig force-pushed the feat/config-filenames-default branch from 5e7133f to 5a09d6f Compare September 8, 2024 12:33
@theoludwig theoludwig changed the title feat: add more config file names by default feat: support .editorconfig-checker.json config Sep 8, 2024
klaernie
klaernie requested changes Sep 8, 2024
View reviewed changes
Copy link
Member
@klaernie klaernie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The technical implementation of searching for config files is correct this way, I would only request that we search for our ideal config file name first (.editorconfig-checker(rc)?.json), then drop the .json suffix (if we actually want to encourage that behaviour) and that fail back to loading .ecrc.

This way users can test their migration to the new file format, and do not get surprised by adding a new config with a syntax error, checking their CI and noticing no problems, then drop their existing config and suddenly run into a problem as the syntax error now gets noticed.

Also having one filename would be better for adding a JSON schema (#194)

ccoVeille
ccoVeille reviewed Sep 8, 2024
View reviewed changes
ccoVeille
ccoVeille reviewed Sep 8, 2024
View reviewed changes
ccoVeille
ccoVeille approved these changes Sep 8, 2024
View reviewed changes
Copy link
Contributor
@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except a side remark on the documentation, I'm fine with current implementation

klaernie
klaernie approved these changes Sep 8, 2024
View reviewed changes
Copy link
Member
@klaernie klaernie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the order in the README, good to go!

@theoludwig @ccoVeille
docs: specify that .ecrc is deprecated
1644b5c 
Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
@theoludwig theoludwig merged commit cb0039c into main Sep 9, 2024
3 checks passed
@theoludwig theoludwig deleted the feat/config-filenames-default branch September 9, 2024 11:10
This was referenced Oct 11, 2024
Merged
Closed
@abuzaforfagun abuzaforfagun mentioned this pull request Oct 11, 2024
Merged
@theoludwig theoludwig mentioned this pull request Jan 5, 2025
Closed
@theoludwig theoludwig mentioned this pull request Jan 5, 2025
Closed
@editorconfig-checker-bot editorconfig-checker-bot mentioned this pull request Jan 6, 2025
Merged
@BrewTestBot BrewTestBot mentioned this pull request Jan 8, 2025
Merged
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Jan 10, 2025
Update module github.com/editorconfig-checker/editorconfig-checker/v3…
98edc27 
…/cmd/editorconfig-checker to v3.1.1 (forgejo) (#6520)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [github.com/editorconfig-checker/editorconfig-checker/v3/cmd/editorconfig-checker](https://github.com/editorconfig-checker/editorconfig-checker) | minor | `v3.0.3` -> `v3.1.1` |

---

### Release Notes

<details>
<summary>editorconfig-checker/editorconfig-checker (github.com/editorconfig-checker/editorconfig-checker/v3/cmd/editorconfig-checker)</summary>

### [`v3.1.1`](https://github.com/editorconfig-checker/editorconfig-checker/releases/tag/v3.1.1)

[Compare Source](editorconfig-checker/editorconfig-checker@v3.1.0...v3.1.1)

##### Bug Fixes

-   dockerfile expected binary at /, not /usr/bin/ [#&#8203;410](editorconfig-checker/editorconfig-checker#410) ([#&#8203;411](editorconfig-checker/editorconfig-checker#411)) ([2c82197](editorconfig-checker/editorconfig-checker@2c82197))

### [`v3.1.0`](https://github.com/editorconfig-checker/editorconfig-checker/releases/tag/v3.1.0)

[Compare Source](editorconfig-checker/editorconfig-checker@v3.0.3...v3.1.0)

##### Features

-   add zip version when compressing all binaries ([#&#8203;321](editorconfig-checker/editorconfig-checker#321)) ([#&#8203;362](editorconfig-checker/editorconfig-checker#362)) ([f1bb625](editorconfig-checker/editorconfig-checker@f1bb625))
-   consolidate adjacent error messages ([#&#8203;360](editorconfig-checker/editorconfig-checker#360)) ([cf4ae1c](editorconfig-checker/editorconfig-checker@cf4ae1c))
-   editorconfig-checker-disable-next-line ([#&#8203;363](editorconfig-checker/editorconfig-checker#363)) ([6116ec6](editorconfig-checker/editorconfig-checker@6116ec6))
-   provide Codeclimate compatible report fromat ([#&#8203;367](editorconfig-checker/editorconfig-checker#367)) ([282c315](editorconfig-checker/editorconfig-checker@282c315))
-   support `.editorconfig-checker.json` config ([#&#8203;375](editorconfig-checker/editorconfig-checker#375)) ([cb0039c](editorconfig-checker/editorconfig-checker@cb0039c))

##### Bug Fixes

-   actually use the correct end marker ([#&#8203;405](editorconfig-checker/editorconfig-checker#405)) ([3c03499](editorconfig-checker/editorconfig-checker@3c03499))
-   add `.ecrc` deprecation warning ([#&#8203;389](editorconfig-checker/editorconfig-checker#389)) ([d33b81c](editorconfig-checker/editorconfig-checker@d33b81c))
-   this release-please marker ([#&#8203;403](editorconfig-checker/editorconfig-checker#403)) ([617c6d4](editorconfig-checker/editorconfig-checker@617c6d4))
-   typo in config, `SpacesAftertabs` => `SpacesAfterTabs` ([#&#8203;386](editorconfig-checker/editorconfig-checker#386)) ([25e3542](editorconfig-checker/editorconfig-checker@25e3542))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "* 0-3 * * *" (UTC), Automerge - "* 0-3 * * *" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45My4wIiwidXBkYXRlZEluVmVyIjoiMzkuOTMuMCIsInRhcmdldEJyYW5jaCI6ImZvcmdlam8iLCJsYWJlbHMiOlsiZGVwZW5kZW5jeS11cGdyYWRlIiwidGVzdC9ub3QtbmVlZGVkIl19-->

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6520
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccoVeille ccoVeille ccoVeille approved these changes

@klaernie klaernie klaernie approved these changes

@mstruebing mstruebing Awaiting requested review from mstruebing

Assignees

@theoludwig theoludwig

Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

Support for .ecrc.json
3 participants
@theoludwig @ccoVeille @klaernie
0