8000 311 resolve technical debt by zale144 · Pull Request #2435 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

311 resolve technical debt #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

zale144
Copy link
@zale144 zale144 commented Mar 26, 2024

Description

Resolves some technical debt that was not addressed in the PR #22

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the correct branch (see PR Targeting)

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed

MalteHerrmann and others added 30 commits March 13, 2023 20:34
* prepare v12 upgrade constants for rc1

* adjust changelog for v12.0.0-rc1

* fix unit test assertion for release candidates
* fix (tests): fix version assertion to be valid for release candidates (evmos#1461)

fix unit test assertion for release candidates

* fix(evm): add gas used (evmos#1466)

* fix(evm): add gas used

* add changelog entry

* add changelog entry

* add changelog entry

* Add TxFeeChecker requirement (evmos#1468)

* add TxFeeChecker requirement

* add unit tests

* update Changelog

* fix(cli) rollback fees auto calculation (evmos#1467)

* chore (ci): update CI workflows to use go v1.20 (evmos#1469)

* update CI workflows to use Go 1.20

* update Dockerfile to use Go 1.20

* address linter

* fix (ci): fix used Go version in CI by passing version as a string (evmos#1471)

fix used Go version in CI by passing version as a string

* chore (ci): remove python from CodeQL action (evmos#1472)

remove python from CodeQL action

* imp(ante): error message (evmos#1470)

* imp(ante): error message

* add changelog entry

* update err msg

* update err msg to be general for all clients

---------

Co-authored-by: Freddy Caceres <facs95@gmail.com>
Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>

* deps: update cosmos-sdk version (evmos#1473)

* deps: update cosmos-sdk version

* add changelog entry

---------

Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>

* update changelog for rc2

* update upgrade constants for rc2

---------

Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: Freddy Caceres <facs95@gmail.com>
* fix: lint issues (evmos#1487)

* Bump Cosmos SDK dependency to v0.46.10-ledger.1

* Update changelog and upgrade handler versions

* Add changelog entry

---------

Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
…os#1522)

* chore: update default timeout_commit to 3s (evmos#1513)

* chore: update default timeout_commit to 3s

* add changelog entry

---------

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
(cherry picked from commit 66d120b)

# Conflicts:
#	CHANGELOG.md

* fix conflicts

---------

Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: tom <tomasguerraalda@hotmail.com>
…#1525)

* fix: parse for websocket connID (evmos#1431)

fix parse for websocket connID

for default types, https://pkg.go.dev/encoding/json#Unmarshal

Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* chore: update changelog with v12.1.1 release and missing entry for evmos#1431 (evmos#1524)

* chore: update changelog with v12.1.1 release and missing entry for evmos#1431

* update changelog

* update changelog

---------

Co-authored-by: mmsqe <tqd0800210105@gmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
evmos#1568)

* feat(client): add subcommand debug legacy-eip712 (evmos#1556)

* feat(client): add subcommand debug legacy-eip712

Signed-off-by: Shane <im.xianying@gmail.com>

* refactor(client): use wrap instead of wrapf

* chore(client): add comment

---------

Signed-off-by: Shane <im.xianying@gmail.com>
Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
(cherry picked from commit 508e2b5)

* fix v12 imports

* add changelog entry

---------

Co-authored-by: Shane <im.xianying@gmail.com>
Co-authored-by: MalteHerrmann <malte@evmos.org>
* fix (ci): fix buf push action version (evmos#1475)

* fix buf push action version

* add changelog entry

---------

Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
(cherry picked from commit 0006a09)

# Conflicts:
#	CHANGELOG.md

* fix conflicts

---------

Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
Co-authored-by: tom <tomasguerraalda@hotmail.com>
…os#1573)

* fix: remove linux/836 from docker image CI  (evmos#1546)

* fix docker build

* fix lint issues

* add changelog entry

* fix md lint issues

---------

Co-authored-by: tom <tomasguerraalda@hotmail.com>
Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
(cherry picked from commit 6b60778)

# Conflicts:
#	CHANGELOG.md
#	LICENSE_FAQ.md
#	README.md

* fix conflicts

---------

Co-authored-by: Freddy Caceres <facs95@gmail.com>
Co-authored-by: tom <tomasguerraalda@hotmail.com>
Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
* fix: add tests and isValid case

* fix: added errotypes

* CHANGELOG

* deps: Bump SDK to v0.46.13

* Update go.mod

Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>

* update changelog

---------

Co-authored-by: Freddy Caceres <facs95@gmail.com>
Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
* update changelog

* fix clawback tests
…striction-from-evm-module

removed the Evmos chain ID enforcement in the EVM module
…mos#1637)

* Problem: cometbft dependency is not updated (evmos#1635)

* Problem: cometbft dependency is not updated

* Update CHANGELOG.md

(cherry picked from commit 3dc4511)

# Conflicts:
#	CHANGELOG.md
#	go.mod

* fix merge conflicts

* fix merge conflicts in go.mod

---------

Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: MalteHerrmann <malte@evmos.org>
feat: Added auto-registration of IBC tokens once recieved on the channel
…support-in-the-erc20-middleware

chore: removed claims reference from the erc20 module
@zale144 zale144 requested a review from a team as a code owner March 26, 2024 17:11
@zale144 zale144 requested review from Vvaradinov and GAtom22 and removed request for a team March 26, 2024 17:11
@CLAassistant
Copy link
CLAassistant commented Mar 26, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 9 committers have signed the CLA.

✅ GAtom22
✅ MalteHerrmann
✅ facs95
✅ Vvaradinov
❌ 0a1c
❌ mergify[bot]
❌ omritoptix
❌ zale144
❌ mtsitrin
You have signed the CLA already but the status is still pending? Let us recheck it.

@zale144 zale144 closed this Mar 26, 2024
@mtsitrin mtsitrin deleted the zale144/311-resolve-technical-debt branch March 27, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants
0