8000 fix: parse for websocket connID by mmsqe · Pull Request #1431 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: parse for websocket connID #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 12, 2023
Merged

fix: parse for websocket connID #1431

merged 6 commits into from
Apr 12, 2023

Conversation

mmsqe
Copy link
Contributor
@mmsqe mmsqe commented Feb 27, 2023

for default types, https://pkg.go.dev/encoding/json#Unmarshal

Description


Closes #XXX

@mmsqe mmsqe requested a review from a team as a code owner February 27, 2023 03:42
@mmsqe mmsqe requested review from Vvaradinov and GAtom22 and removed request for a team February 27, 2023 03:42
Copy link
Collaborator
@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmsqe, I'll mark this as draft until we merge the PR on Ethermint

Copy link
Contributor
@GAtom22 GAtom22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mmsqe !

@GAtom22 GAtom22 requested a review from fedekunze March 22, 2023 18:22
@CLAassistant
Copy link
CLAassistant commented Mar 31, 2023

CLA assistant check
All committers have signed the CLA.

@fedekunze
Copy link
Collaborator

@mmsqe could you please sign the CLA?

@fedekunze fedekunze enabled auto-merge (squash) April 12, 2023 14:52
@fedekunze fedekunze merged commit c348527 into evmos:main Apr 12, 2023
fedekunze pushed a commit that referenced this pull request Apr 14, 2023
 (#1524)

* chore: update changelog with v12.1.1 release and missing entry for #1431

* update changelog
GAtom22 added a commit that referenced this pull request Apr 14, 2023
fix parse for websocket connID

for default types, https://pkg.go.dev/encoding/json#Unmarshal

Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
GAtom22 added a commit that referenced this pull request Apr 14, 2023
 (#1524)

* chore: update changelog with v12.1.1 release and missing entry for #1431

* update changelog
fedekunze added a commit that referenced this pull request Apr 14, 2023
* fix: parse for websocket connID (#1431)

fix parse for websocket connID

for default types, https://pkg.go.dev/encoding/json#Unmarshal

Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* chore: update changelog with v12.1.1 release and missing entry for #1431 (#1524)

* chore: update changelog with v12.1.1 release and missing entry for #1431

* update changelog

* update changelog

---------

Co-authored-by: mmsqe <tqd0800210105@gmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0