-
Notifications
You must be signed in to change notification settings - Fork 898
fix: parse for websocket connID #1431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for default types, https://pkg.go.dev/encoding/json#Unmarshal
fedekunze
requested changes
Feb 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mmsqe, I'll mark this as draft until we merge the PR on Ethermint
GAtom22
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @mmsqe !
@mmsqe could you please sign the CLA? |
fedekunze
approved these changes
Apr 12, 2023
GAtom22
added a commit
that referenced
this pull request
Apr 14, 2023
GAtom22
added a commit
that referenced
this pull request
Apr 14, 2023
fix parse for websocket connID for default types, https://pkg.go.dev/encoding/json#Unmarshal Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
fedekunze
added a commit
that referenced
this pull request
Apr 14, 2023
* fix: parse for websocket connID (#1431) fix parse for websocket connID for default types, https://pkg.go.dev/encoding/json#Unmarshal Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * chore: update changelog with v12.1.1 release and missing entry for #1431 (#1524) * chore: update changelog with v12.1.1 release and missing entry for #1431 * update changelog * update changelog --------- Co-authored-by: mmsqe <tqd0800210105@gmail.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for default types, https://pkg.go.dev/encoding/json#Unmarshal
Description
Closes #XXX