8000 fix (ci): fix buf push action version by MalteHerrmann · Pull Request #1475 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix (ci): fix buf push action version #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 17, 2023
Merged

fix (ci): fix buf push action version #1475

merged 6 commits into from
Mar 17, 2023

Conversation

MalteHerrmann
Copy link
Contributor

Description

The GitHub action to push to the Buf Schema Registry did not work because of a non-existent version being defined. This is fixed in this PR.

See the releases of the action at bufbuild/buf-push-action.

@MalteHerrmann MalteHerrmann requested a review from a team as a code owner March 15, 2023 21:15
@MalteHerrmann MalteHerrmann requested review from Vvaradinov and austinchandra and removed request for a team March 15, 2023 21:15
@github-actions github-actions bot added the CI label Mar 15, 2023
GAtom22
GAtom22 approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor
@GAtom22 GAtom22 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work @MalteHerrmann !!
Can you add a changelog entry for this?

@MalteHerrmann MalteHerrmann merged commit 0006a09 into main Mar 17, 2023
@MalteHerrmann MalteHerrmann deleted the malte/fix-bsr-push-action branch March 17, 2023 07:45
@GAtom22
Copy link
Contributor
GAtom22 commented May 25, 2023

https://github.com/Mergifyio backport release/v12.x.x

@mergify
Copy link
Contributor
mergify bot commented May 25, 2023 •
edited
Loading

backport release/v12.x.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 25, 2023
@MalteHerrmann @mergify
fix (ci): fix buf push action version (#1475)
7ccd248 
* fix buf push action version

* add changelog entry

---------

Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
(cherry picked from commit 0006a09)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request May 25, 2023
Merged
GAtom22 added a commit that referenced this pull request May 25, 2023
@mergify @MalteHerrmann @GAtom22
fix (ci): fix buf push action version (backport #1475) (#1572)
c7f8caf 
* fix (ci): fix buf push action version (#1475)

* fix buf push action version

* add changelog entry

---------

Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
(cherry picked from commit 0006a09)

# Conflicts:
#	CHANGELOG.md

* fix conflicts

---------

Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
Co-authored-by: tom <tomasguerraalda@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GAtom22 GAtom22 GAtom22 approved these changes

@Vvaradinov Vvaradinov Awaiting requested review from Vvaradinov Vvaradinov is a code owner automatically assigned from evmos/core-engineering

@austinchandra austinchandra Awaiting requested review from austinchandra austinchandra is a code owner automatically assigned from evmos/core-engineering

Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MalteHerrmann @GAtom22
0