feat: create erc20 contract on denom metadata registration #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwt
requested changes
Mar 22, 2024
mtsitrin
reviewed
Mar 24, 2024
hoangdv2429
reviewed
Mar 25, 2024
10000
mtsitrin
approved these changes
Mar 26, 2024
omritoptix
approved these changes
Mar 26, 2024
danwt
approved these changes
Mar 26, 2024
Comment on lines
+72
to
+77
| err := e.AfterDenomMetadataCreation(sdk.Context{}, tt.args.newDenomMetadata) | ||
| if tt.expectErr != "" { | ||
| require.EqualError(t, err, tt.expectErr) | ||
| } else { | ||
| require.NoError(t, err) | ||
| } |
There was a problem hiding this comment.
can we replace the errors with Err* types and use require.True(t, errors.Is(err, ErrFoo))
| // short-circuit: if the denom is not registered, conversion will fail | ||
| // so we can continue with the rest of the stack | ||
| return ack | ||
| err = errorsmod.Wrapf(types.ErrTokenPairNotFound, "token pair not found for %s", coin.Denom) |
There was a problem hiding this comment.
Suggested change
| err = errorsmod.Wrapf(types.ErrTokenPairNotFound, "token pair not found for %s", coin.Denom) | |
| err = errorsmod.Wrapf(types.ErrTokenPairNotFound, "token pair not found: denom: %s", coin.Denom) |
|
Approved but I left an improvement for the test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #dymension-rdk/311