feat(crypto): adding secp256k1 with Ethereum format
#2534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergio-mena
commented
Mar 8, 2024
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
… and thread it through the code (#3517) Contributes to #2424 Precondition for #2534 This PR is inspired in the core idea of #2539, by @tac0turtle, whereby we make `privval` more flexible to generate privval files in all the curves we support in CometBFT natively. The flag `key-type`, which was only part of command `gen-validator`before this PR, is now part of all commands that _may_ generate priv validator keys (`start`, `unsafe-reset-all`, `unsafe-reset-priv-validator`, `init`). Importantly, node key, and node key file generation is still hard-coded to `ed25519` (no need to change it for the time being). Still TODO: * Add unit tests at various places to test the different key types --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
mergify bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
… and thread it through the code (#3517) Contributes to #2424 Precondition for #2534 This PR is inspired in the core idea of #2539, by @tac0turtle, whereby we make `privval` more flexible to generate privval files in all the curves we support in CometBFT natively. The flag `key-type`, which was only part of command `gen-validator`before this PR, is now part of all commands that _may_ generate priv validator keys (`start`, `unsafe-reset-all`, `unsafe-reset-priv-validator`, `init`). Importantly, node key, and node key file generation is still hard-coded to `ed25519` (no need to change it for the time being). Still TODO: * Add unit tests at various places to test the different key types --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> (cherry picked from commit bd06fec) # Conflicts: # cmd/cometbft/commands/gen_validator.go # node/errors.go # node/node_test.go # privval/file.go
4 tasks
melekes
added a commit
that referenced
this pull request
Aug 6, 2024
… and thread it through the code (backport #3517) (#3630) Contributes to #2424 Precondition for #2534 This PR is inspired in the core idea of #2539, by @tac0turtle, whereby we make `privval` more flexible to generate privval files in all the curves we support in CometBFT natively. The flag `key-type`, which was only part of command `gen-validator`before this PR, is now part of all commands that _may_ generate priv validator keys (`start`, `unsafe-reset-all`, `unsafe-reset-priv-validator`, `init`). Importantly, node key, and node key file generation is still hard-coded to `ed25519` (no need to change it for the time being). Still TODO: * Add unit tests at various places to test the different key types --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #3517 done by [Mergify](https://mergify.com). --------- Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
sergio-mena
commented
Dec 19, 2024
sergio-mena
commented
Dec 19, 2024
sergio-mena
commented
Dec 19, 2024
sergio-mena
commented
Dec 19, 2024
sergio-mena
commented
Dec 19, 2024
There was a problem hiding this comment.
LGTM. Only minor comments.
Thanks a lot @bermuell for taking this over the finish line! 🚀
jmalicevic
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
This PR was implemented by @bermuell and approving based on feedback from @sergio-mena and a pass over it myself. Thank you for this!
melekes
reviewed
Dec 20, 2024
Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: Sergio Mena <sergio@informal.systems>
melekes
approved these changes
Dec 21, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 25, 2024
Follow-up to #2534 Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the secp256k1-eth crypto codec.
This includes functionality for generating and verifying
Ethereum-compatible signatures using the secp256k1 curve.
Post Merge follow up
secp256k1eth#4726secp256k1eth#4725MaxSignatureSizeto include secp256k1eth #4727PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments