8000 fix(spec): Update spec with info on signature size of `secp256k1eth` by jmalicevic · Pull Request #4726 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(spec): Update spec with info on signature size of secp256k1eth #4726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2024
Merged

fix(spec): Update spec with info on signature size of secp256k1eth #4726

merged 1 commit into from
Dec 24, 2024

Conversation

jmalicevic
Copy link
Contributor

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@jmalicevic jmalicevic added bug Something isn't working spec Specification-related labels Dec 24, 2024
@jmalicevic jmalicevic added this to the 2024-Q4 milestone Dec 24, 2024
@jmalicevic jmalicevic self-assigned this Dec 24, 2024
@jmalicevic jmalicevic requested review from a team as code owners December 24, 2024 12:29
@jmalicevic jmalicevic mentioned this pull request Dec 24, 2024
Merged
7 tasks
melekes
melekes approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor
@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jmalicevic jmalicevic added this pull request to the merge queue Dec 24, 2024
Merged via the queue into main with commit 470f41b Dec 24, 2024
35 checks passed
@jmalicevic jmalicevic deleted the jasmina/tmp-fix-spec-secp256k1eth branch December 24, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melekes melekes melekes approved these changes

Assignees

@jmalicevic jmalicevic

Labels
bug Something isn't working spec Specification-related
Projects
No open projects
CometBFT
Status: Done
Milestone
2024-Q4
Development

Successfully merging this pull request may close these issues.
2 participants
@jmalicevic @melekes
0