8000 feat(cmd): Add build flag for `secp256k1eth` · Issue #4725 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(cmd): Add build flag for secp256k1eth #4725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #2534
jmalicevic opened this issue Dec 24, 2024 · 0 comments · Fixed by #4784
Closed
Tracked by #2534

feat(cmd): Add build flag for secp256k1eth #4725

jmalicevic opened this issue Dec 24, 2024 · 0 comments · Fixed by #4784
Assignees
@bermuell
Labels
crypto Cryptography-related enhancement New feature or request

Comments

@jmalicevic
Copy link
Contributor
jmalicevic commented Dec 24, 2024 •
edited by sergio-mena
Loading

PR #2534 adds support for the secp256k1eth crypto codec in order to generate and validate Ethereum compatible signatures.

Similarly to BLS, until this crypto undergoes proper auditing and gets battle-tested to a certain extent, it is judicious to hide it behind a build flag so that this is included into the CometBFT binary only when the flag is present.

As mentioned, the same approach was taken when adding support for the BLS12-381 curve in #2765. This PR can be used as the starting point for this work, but it was followed with several PRs to fix or improve things that were initially missed.
@jmalicevic jmalicevic added enhancement New feature or request needs-triage This issue/PR has not yet been triaged by the team. labels Dec 24, 2024
@github-project-automation github-project-automation bot moved this to Todo in CometBFT Dec 24, 2024
@jmalicevic jmalicevic added crypto Cryptography-related and removed needs-triage This issue/PR has not yet been triaged by the team. labels Dec 24, 2024
@jmalicevic jmalicevic mentioned this issue Dec 24, 2024
Merged
7 tasks
@bermuell bermuell mentioned this issue Jan 7, 2025
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 9, 2025
@bermuell @mergify
fix: Added build flag for secp256k1eth curve (#4784)
0d4d40f 
---
closes #4725 

#### PR checklist

- [x] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from Todo to Done in CometBFT Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bermuell bermuell

Labels
crypto Cryptography-related enhancement New feature or request
Projects
No open projects
CometBFT
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Added build flag for secp256k1eth curve cometbft/cometbft
2 participants
@jmalicevic @bermuell
0