8000 fix(types): update `MaxSignatureSize` to include secp256k1eth by melekes · Pull Request #4727 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(types): update MaxSignatureSize to include secp256k1eth #4727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 25, 2024
Merged

fix(types): update MaxSignatureSize to include secp256k1eth #4727

merged 2 commits into from
Dec 25, 2024

Conversation

melekes
Copy link
Contributor
@melekes melekes commented Dec 24, 2024 •
edited
Loading

Follow-up to #2534

@melekes melekes requested review from a team as code owners December 24, 2024 14:23
@melekes melekes added the crypto Cryptography-related label Dec 24, 2024
@melekes melekes self-assigned this Dec 24, 2024
@melekes melekes changed the title fix(types): update MaxSignatureSize to include secp256k1eth fix(types): update MaxSignatureSize to include secp256k1eth Dec 24, 2024
jmalicevic
jmalicevic approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor
@jmalicevic jmalicevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@melekes melekes enabled auto-merge December 24, 2024 14:29
@melekes melekes added this pull request to the merge queue Dec 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 24, 2024
@jmalicevic jmalicevic mentioned this pull request Dec 24, 2024
Merged
7 tasks
@melekes melekes added this pull request to the merge queue Dec 25, 2024
Merged via the queue into main with commit 80a972d Dec 25, 2024
33 checks passed
@melekes melekes deleted the melekes/tmp-fix-maxsize-secp256k1eth branch December 25, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmalicevic jmalicevic jmalicevic approved these changes

Assignees

@melekes melekes

Labels
crypto Cryptography-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melekes @jmalicevic
0