8000 Templates: Remove redhat_management_type usages by SchoolGuy · Pull Request #2991 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Templates: Remove redhat_management_type usages #2991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

SchoolGuy
Copy link
Member

The key was removed from Cobbler in V3.0.0, and thus we need to remove code
which use this key.

The file "rhn_certificate_based_register" was not used in any other template
and was thus removed.

Fixes #2943

The key was removed from Cobbler in V3.0.0, and thus we need to remove code
which use this key.

The file "rhn_certificate_based_register" was not used in any other template
and was thus removed.
@SchoolGuy SchoolGuy added this to the v3.4.0 milestone Mar 23, 2022
@SchoolGuy SchoolGuy requested a review from a team March 23, 2022 08:36
@codecov
Copy link
codecov bot commented Mar 23, 2022

Codecov Report

Merging #2991 (e48c18a) into main (873cb14) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2991   +/-   ##
=======================================
  Coverage   62.03%   62.03%           
=======================================
  Files         102      102           
  Lines       14428    14428           
=======================================
  Hits         8950     8950           
  Misses       5478     5478           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 873cb14...e48c18a. Read the comment docs.

Copy link
Contributor
@vzhestkov vzhestkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchoolGuy SchoolGuy merged commit 83c6271 into main Mar 24, 2022
@SchoolGuy SchoolGuy deleted the fix/redhat-management-type branch March 24, 2022 09:39
SchoolGuy added a commit that referenced this pull request Apr 19, 2022
This backports:

- #2972
- #2973
- #2974
- #2976
- #2985
- #2986
- #2989
- #2990
- #2991
- #2996
- #3008
- #3009
- #3017

The exact content of the patches can please be taken from the Pull Requests on
GitHub.
SchoolGuy added a commit that referenced this pull request Apr 20, 2022
This backports:

- #2973
- #2974
- #2976
- #2985
- #2986
- #2989
- #2990
- #2991
- #2996
- #3008
- #3009
- #3017

The exact content of the patches can please be taken from the Pull Requests on
GitHub.
SchoolGuy added a commit that referenced this pull request Apr 20, 2022
This backports:

- #2973
- #2974
- #2976
- #2985
- #2986
- #2989
- #2990
- #2991
- #2996
- #3008
- #3009
- #3017

The exact content of the patches can please be taken from the Pull Requests on
GitHub.
SchoolGuy added a commit that referenced this pull request Apr 20, 2022
This backports:

- #2973
- #2974
- #2976
- #2985
- #2986
- #2989
- #2990
- #2991
- #2996
- #3008
- #3009
- #3017

The exact content of the patches can please be taken from the Pull Requests on
GitHub.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

redhat_management_type references linger in included snippets
3 participants
0