8000 redhat_management_type references linger in included snippets · Issue #2943 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

redhat_management_type references linger in included snippets #2943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
draeath opened this issue Feb 16, 2022 · 0 comments · Fixed by #2991
Closed

redhat_management_type references linger in included snippets #2943

draeath opened this issue Feb 16, 2022 · 0 comments · Fixed by #2991
Labels
3.2.2 Release 3.2.2 3.3.1 Release 3.3.1 Bug Report Reporting a bug
Milestone
v3.4.0

Comments

@draeath
Copy link
draeath commented Feb 16, 2022 •
edited
Loading

Describe the bug

Kickstart templates referencing the as-provided redhat_register and rhn_certificate_based_register snippets fail to parse as they still reference a removed variable redhat_management_type

Steps to reproduce

  1. install cobbler 3.2 or 3.3
  2. attempt to use either snippet
  3. observe cobbler log and the rendered kickstart

Expected behavior

Correct rendering of the included templates/snippets.

Cobbler version

Cobbler 3.2.2
  source: ?, ?
  build time: Mon Jan 24 02:22:30 2022

# verified this is a problem in master, however

Operating system

Cobbler log

2022-02-16T18:29:44 - WARNING | errors were encountered rendering the template
2022-02-16T18:29:44 - WARNING | 
[{'code': 'VFFSL(SL,"SNIPPET",False)(\'redhat_register\')',
  'exc_val': NotFound("cannot find 'redhat_management_type'",),
  'lineCol': (70, 1),
  'rawCode': "$SNIPPET('redhat_register')",
  'time': 'Wed Feb 16 18:29:44 2022'}]

Screenshots

N/A

Additional information

This reference is still erroneously present in master and does not just affect 3.2:

It appears it was removed in 3.0.0 and the snippets were not adjusted accordingly. They have been broken since.

This causes an early abort of the installation (note the unexpanded $SNIPPET() shortly after the koan setup)

# Start koan environment setup
echo "export COBBLER_SERVER=cobbler1.epi.usf.edu" > /etc/profile.d/cobbler.sh
echo "setenv COBBLER_SERVER cobbler1.epi.usf.edu" > /etc/profile.d/cobbler.csh
# End koan environment setup

$SNIPPET('redhat_register')
# Begin cobbler registration
# skipping for system-based installation
# End cobbler registration
@draeath draeath added the Bug Report Reporting a bug label Feb 16, 2022
@SchoolGuy SchoolGuy added 8000 3.2.2 Release 3.2.2 3.3.1 Release 3.3.1 labels Feb 21, 2022
@SchoolGuy SchoolGuy added this to the v3.3.2 milestone Feb 21, 2022
@SchoolGuy SchoolGuy modified the milestones: v3.3.2, v3.4.0 Mar 11, 2022
@SchoolGuy SchoolGuy mentioned this issue Mar 23, 2022
Merged
@SchoolGuy SchoolGuy moved this to Todo in Cobbler Server Jul 3, 2022
@SchoolGuy SchoolGuy moved this from Todo to Done in Cobbler Server Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.2.2 Release 3.2.2 3.3.1 Release 3.3.1 Bug Report Reporting a bug
Projects
Cobbler Server
Status: Done
Milestone
v3.4.0
Development

Successfully merging a pull request may close this issue.

Templates: Remove redhat_management_type usages cobbler/cobbler
2 participants
@draeath @SchoolGuy
0