8000 System Remove: Fix system "default" GRUB case by SchoolGuy · Pull Request #3009 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

System Remove: Fix system "default" GRUB case #3009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2022
Merged

System Remove: Fix system "default" GRUB case #3009

merged 1 commit into from
Mar 30, 2022

Conversation

SchoolGuy
Copy link
Member

Before this commit we did not skip removing the GRUB bootloader for the system
named "default". This caused the removal of a system to fail. After skipping this
now a removal of a system named "default" should work again.

@SchoolGuy SchoolGuy added this to the v3.4.0 milestone Mar 30, 2022
@SchoolGuy SchoolGuy requested a review from a team March 30, 2022 11:39
meaksh
meaksh approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member
@meaksh meaksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SchoolGuy
System Remove: Fix system "default" GRUB case
da40afb 
Before this commit we did not skip removing the GRUB bootloader for the system
named "default". This caused the removal of a system to fail. After skipping this
now a removal of a system named "default" should work again.
@SchoolGuy SchoolGuy force-pushed the fix/default-system-grub branch from 112e415 to da40afb Compare March 30, 2022 16:59
@SchoolGuy
Copy link
Member Author

The reposync tests are definitely not related to this change. Thus I will ignore them for now. We need to stabilize them long-term.

@SchoolGuy SchoolGuy merged commit 0fa0874 into main Mar 30, 2022
@SchoolGuy SchoolGuy deleted the fix/default-system-grub branch March 30, 2022 18:40
@SchoolGuy SchoolGuy mentioned this pull request Apr 19, 2022
Closed
3 tasks
SchoolGuy added a commit that referenced this pull request Apr 19, 2022
@SchoolGuy
Backport of multiple PRs from the main branch
6d8a8e5 
This backports:

- #2972
- #2973
- #2974
- #2976
- #2985
- #2986
- #2989
- #2990
- #2991
- #2996
- #3008
- #3009
- #3017

The exact content of the patches can please be taken from the Pull Requests on
GitHub.
@SchoolGuy SchoolGuy mentioned this pull request Apr 19, 2022
Merged
SchoolGuy added a commit that referenced this pull request Apr 20, 2022
@SchoolGuy
Backport of multiple PRs from the main branch
e92a53e 
This backports:

- #2973
- #2974
- #2976
- #2985
- #2986
- #2989
- #2990
- #2991
- #2996
- #3008
- #3009
- #3017

The exact content of the patches can please be taken from the Pull Requests on
GitHub.
SchoolGuy added a commit that referenced this pull request Apr 20, 2022
@SchoolGuy
Backport of multiple PRs from the main branch
28735c4 
This backports:

- #2973
- #2974
- #2976
- #2985
- #2986
- #2989
- #2990
- #2991
- #2996
- #3008
- #3009
- #3017

The exact content of the patches can please be taken from the Pull Requests on
GitHub.
SchoolGuy added a commit that referenced this pull request Apr 20, 2022
@SchoolGuy
Backport of multiple PRs from the main branch
2511350 
This backports:

- #2973
- #2974
- #2976
- #2985
- #2986
- #2989
- #2990
- #2991
- #2996
- #3008
- #3009
- #3017

The exact content of the patches can please be taken from the Pull Requests on
GitHub.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meaksh meaksh meaksh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Cobbler Server
Status: Done
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SchoolGuy @meaksh
0