Settings: Add proxies key #2989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b607b9f to
b6875a8
Compare
Codecov Report
@@ Coverage Diff @@
## main #2989 +/- ##
==========================================
- Coverage 62.03% 62.02% -0.01%
==========================================
Files 102 102
Lines 14428 14427 -1
==========================================
- Hits 8950 8949 -1
Misses 5478 5478
Continue to review full report at Codecov.
|
|
I will wait with merging this until it was tested by @nodeg and me. Maybe I have forgotten something the CI didn't catch. |
This commit introduces first-level support for Uyuni Proxies. The only thing missing for this was to allow a new settings key called "proxies". The name is not perfect for the moment, but changing the name to a more fitting one will be done in a future version to make the changes minimal for both Uyuni and Cobbler users alike. More explanation for this feature of Uyuni can be found the linked document in "cobbler-conf.rst". Co-authored-by: Dominik Gedon <dgedon@suse.de>
9c0b143 to
932ae76
Compare
SchoolGuy
added a commit
that referenced
this pull request
Apr 19, 2022
This was referenced Apr 19, 2022
SchoolGuy
added a commit
that referenced
this pull request
Apr 20, 2022
SchoolGuy
added a commit
that referenced
this pull request
Apr 20, 2022
SchoolGuy
added a commit
that referenced
this pull request
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces first-level support for Uyuni Proxies. The only thing
missing for this was to allow a new settings key called "proxies". The name is
not perfect for the moment, but changing the name to a more fitting one will be
done in a future version to make the changes minimal for both Uyuni and Cobbler
users alike.
More explanation for this feature of Uyuni can be found the linked document in
"cobbler-conf.rst".
Fixes #2988