8000 components: remove `unsafe` from ProcessLoaderSequential by bradjc · Pull Request #4436 · tock/tock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

components: remove unsafe from ProcessLoaderSequential #4436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025

Conversation

bradjc
Copy link
Contributor
@bradjc bradjc commented May 14, 2025

Pull Request Overview

The unsafe was needed for creating the slices to the process flash and memory regions. Those have been moved to main.rs.

Testing Strategy

travis

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

bradjc added 2 commits May 14, 2025 13:54
The unsafe was needed for creating the slides to the process flash and
memory regions. Those have been moved to main.rs.
Copy link
Member
@alevy alevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like something that should, perhaps, move to the build_scripts crate since it's really logic that is pretty closely tied to the specific linker script used from that crate.

But this is good for now, IMO.

@alevy alevy added this pull request to the merge queue May 15, 2025
Merged via the queue into master with commit c5145e6 May 15, 2025
21 checks passed
@alevy alevy deleted the components-unsafe-process-loader-seq branch May 15, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0