boards: tutorials: add nrf52840dk-dynamic-apps-and-policies #4420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradjc
reviewed
Apr 30, 2025
boards/tutorials/nrf52840dk-process-control/jtag/gdbinit_pca10040.jlink
Outdated
Show resolved
Hide resolved
boards/tutorials/nrf52840dk-process-control/jtag/jdbserver_pca10040.sh
Outdated
Show resolved
Hide resolved
bradjc
reviewed
May 1, 2025
boards/tutorials/nrf52840dk-dynamic-apps-and-policies/src/main.rs
Outdated
Show resolved
Hide resolved
boards/tutorials/nrf52840dk-dynamic-apps-and-policies/src/main.rs
Outdated
Show resolved
Hide resolved
boards/tutorials/nrf52840dk-dynamic-apps-and-policies/src/main.rs
Outdated
Show resolved
Hide resolved
boards/tutorials/nrf52840dk-dynamic-apps-and-policies/src/main.rs
Outdated
Show resolved
Hide resolved
boards/tutorials/nrf52840dk-dynamic-apps-and-policies/src/io.rs
Outdated
Show resolved
Hide resolved
boards/tutorials/nrf52840dk-dynamic-apps-and-policies/src/main.rs
Outdated
Show resolved
Hide resolved
ppannuto
requested changes
May 7, 2025
|
|
||
| This is the board definition for the nRF52840DK target used in the | ||
| [Dynamic App Loading and Secure Policies] | ||
| (https://github.com/tock/book/pull/60/files). |
There was a problem hiding this comment.
This is an unfortunate chicken-and-egg situation; fine for the moment, just make sure you have a note somewhere to update this when tock/book#60 lands
(non-blocking comment)
boards/tutorials/nrf52840dk-dynamic-apps-and-policies/src/main.rs
Outdated
Show resolved
Hide resolved
Comment on lines
448
to
453
| //-------------------------------------------------------------------------- | ||
| // SCREEN | ||
| //-------------------------------------------------------------------------- | ||
|
|
||
| const SCREEN_I2C_SDA_PIN: Pin = Pin::P1_10; | ||
| const SCREEN_I2C_SCL_PIN: Pin = Pin::P1_11; |
There was a problem hiding this comment.
oof; not a problem this PR needs to fix, but this is the third time we're copy-pasting this block; we should componentize this somehow
(non-blocking comment)
ppannuto
reviewed
May 7, 2025
boards/tutorials/nrf52840dk-dynamic-apps-and-policies/src/main.rs
Outdated
Show resolved
Hide resolved
a8e525e to
ca6ca9d
Compare
6d9c9ff to
ca6ca9d
Compare
|
The seq. process loader component changed to move the unsafe operation to main.rs. Need to copy the change from #4436 |
…vm and make types for some capsules
b5549f6 to
d590be7
Compare
Uses the name and the verifying key index.
Try to make it clear
ppannuto
approved these changes
May 20, 2025
Comment on lines
+32
to
+34
| 0 => Ok(()), | ||
| 1 => Ok(()), | ||
| _ => Ok(()), |
There was a problem hiding this comment.
Is this WIP code, or is this a placeholder that tutorial participants are intended to update [if the latter, perhaps indicate with comments?]
alevy
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…docs
Pull Request Overview
This pull request adds the tutorial board for the process control tutorial for mobisys '25.
Testing Strategy
It is untested because I did not want to upload the process-info capsule while it is still under review and is seeing changes. It worked with a previous iteration of the capsule.
TODO or Help Wanted
@bradjc can test with his local copy of process-info capsule
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.