BBC HiFive Inventor board ported to Tock #3225
Conversation
| #![allow(dead_code)] | ||
|
|
There was a problem hiding this comment.
| #![allow(dead_code)] |
There was a problem hiding this comment.
Because not all interrupts are treated in service_interrupt() removing that line would result in useless warnings.
There was a problem hiding this comment.
Perhaps then make these pub(crate)? I removed the allow from g002 and didn't get any warnings.
There was a problem hiding this comment.
When I removed the pub in lib.rs I got the something like: warning: constant is never used.
There was a problem hiding this comment.
I think you are referring deleting pub from pub mod interrupts;
|
I've built and run Tock on my HiFive1 RevB, and it appears to be working fine. UART works, I can load applications. Haven't tested it any more extensively than that, though. |
|
@bradjc I have now tested myself the |
That seems fine with me. |
|
Thanks. I just removed it. |
|
bors r+ |
Pull Request Overview
This pull request aims to port Tock to the BBC HiFive Inventor board.
The source is mostly copied from the SiFive HiFive1 Rev B board.
I followed an earlier attempt, made by @TeodoraMiu, who tried to:
layout.ldHowever the problems noticed with the UART speed were caused by a lack of configuration of the internal frequency. This was solved by merge #3215. (The code is also commited here.)
Still there were some bugs in the original
sifivecrate. When trying to clear all pending PL-interrupts a read-only register is overwritten.The manual states another way to clear interrupts, by reading the
claimregister and writing the (or a) value back. See this commit.The new HiFive board featured a different chip which didn't use the same indexing of interrupt numbers. So implementing a different
InterruptServicefor each chip was necessary. So thee310xchip implementation was split in two,e310_g002ande310_g003, which handle each interrupt number differently.I also added the second UART peripheral in order to disable any unwanted interrupts from it.
Testing Strategy
This pull request was tested by checking the serial output of the
hifive_inventortarget and thehifive1qemu simulation.Help Wanted
This pull request still needs to be physically tested on a hifive1 board.
@gemarcano could you please do this?
Documentation Updated
Formatting
make prepush.