opentitan: add watchdog/aon_timer #3208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradjc
previously approved these changes
Sep 12, 2022
hudson-ayers
previously approved these changes
Sep 12, 2022
|
Ping! @alistair23 |
alistair23
reviewed
Sep 29, 2022
alistair23
previously approved these changes
Sep 29, 2022
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 29, 2022
3208: opentitan: add watchdog/aon_timer r=bradjc a=twilfredo ### Pull Request Overview Uses the `Always on timer` (AON_TIMER) for Opentitan [hw_ip](https://docs.opentitan.org/hw/ip/aon_timer/doc/), to implement watchdog for OpenTitan. This AON_TIMER has both a `watchdog` timer and a `wakeup` timer. The driver implemented has support for both hw functionality but only runs the watch dog timer for now (unused code tagged with `#[cfg(aon_wkup_timer)]`, that should be (?) compiled out and is left for reference/use later. The following patch for [qemu](https://www.mail-archive.com/qemu-devel@nongnu.org/msg907656.html) adds support to the watchdog, so we can use this in the future with qemu also. ### Testing Strategy Driver has been written to support to latest version of OpenTitan supported by TockOS, testing was done on Verilator on this #3056. ### TODO - Tested on Verilator, would be good to test on CW130 (since the AON_TIMER runs on different clock rates on both devices) - Implement a WakeUp timer interface (?) and connect it to this driver. ### Documentation Updated - [x] No updates are required. ### Formatting - [x] Ran `make prepush`. Co-authored-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
|
Build failed: |
Add aon_timer hwip driver support, hardware specification as per [1]. [1] https://docs.opentitan.org/hw/ip/aon_timer/doc/ Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
de362c2
6edee45 to
de362c2
Compare
|
Rebased, interrupt line names had changed in the recent OT bump. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 30, 2022
3208: opentitan: add watchdog/aon_timer r=alistair23 a=twilfredo ### Pull Request Overview Uses the `Always on timer` (AON_TIMER) for Opentitan [hw_ip](https://docs.opentitan.org/hw/ip/aon_timer/doc/), to implement watchdog for OpenTitan. This AON_TIMER has both a `watchdog` timer and a `wakeup` timer. The driver implemented has support for both hw functionality but only runs the watch dog timer for now (unused code tagged with `#[cfg(aon_wkup_timer)]`, that should be (?) compiled out and is left for reference/use later. The following patch for [qemu](https://www.mail-archive.com/qemu-devel@nongnu.org/msg907656.html) adds support to the watchdog, so we can use this in the future with qemu also. ### Testing Strategy Driver has been written to support to latest version of OpenTitan supported by TockOS, testing was done on Verilator on this #3056. ### TODO - Tested on Verilator, would be good to test on CW130 (since the AON_TIMER runs on different clock rates on both devices) - Implement a WakeUp timer interface (?) and connect it to this driver. ### Documentation Updated - [x] No updates are required. ### Formatting - [x] Ran `make prepush`. Co-authored-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
bradjc
approved these changes
Sep 30, 2022
|
bors r+ |
This was referenced Jun 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Uses the
Always on timer(AON_TIMER) for Opentitan hw_ip, to implement watchdog for OpenTitan.This AON_TIMER has both a
watchdogtimer and awakeuptimer. The driver implemented has support for both hw functionality but only runs the watch dog timer for now (unused code tagged with#[cfg(aon_wkup_timer)], that should be (?) compiled out and is left for reference/use later.The following patch for qemu adds support to the watchdog, so we can use this in the future with qemu also.
Testing Strategy
Driver has been written to support to latest version of OpenTitan supported by TockOS, testing was done on Verilator on this #3056.
TODO
Documentation Updated
Formatting
make prepush.