Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ska3-matlab 2021.3
Summary:
This is an incremental update of ska3-matlab with package changes to support the expanded AGASC supplement.
Interface Impacts:
AGASC access
Code that uses the
agasc
Python package to access star data will use updated magnitude information from the AGASC supplement by default. This can be controlled by the AGASC_SUPPLEMENT_ENABLED environment variable, by use of theagasc.set_supplement_enabled()
method, or by explicit use of theuse_supplement
argument in the methods. See https://sot.github.io/agasc/api.html for theagasc
documentation as needed.Testing:
Current release candidate is available for testing in the
test
conda channel:The version of the agasc supplement file that will be promoted with ska3-matlab 2021.3 is:
https://cxc.cfa.harvard.edu/mta/ASPECT/agasc/supplement/flight-promotion-2021.3/agasc_supplement.h5
(md5sum f676a119760405813c85823c96a0bc9e ).
Review
Deployment:
Code changes
ska3-matlab changes (2020.13+shiny -> 2021.3rc1)
New Packages
Updated Packages
ska3-core changes (2020.13+shiny -> 2021.2)
New Packages
Updated Packages
Related Issues
Fixes #609
Fixes #612
Fixes #613
Fixes #614