8000 Fix bug getting states starting between AOUPTARQ and AOMANUVR by taldcroft · Pull Request #199 · sot/kadi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix bug getting states starting between AOUPTARQ and AOMANUVR #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

taldcroft
Copy link
Member

Description

When the start time was between AOUPTARQ and AOMANUVR commands, this led to an exception because the code was trying to insert pseudo-commanding for that maneuver, but did not yet have a defined target attitude. This led to a failure in the maneuver generating code since it was being passed None for an attitude value.

Testing

  • Passes unit tests on MacOS
  • Functional testing (New unit test)

Fixes #198

@taldcroft taldcroft added the bug label Feb 2, 2021
@taldcroft taldcroft requested a review from jeanconn February 2, 2021 20:48
@taldcroft
Copy link
Member Author

This is a critical bug so we should get it into 2021.2.

@taldcroft taldcroft merged commit b8beda3 into master Feb 2, 2021
@taldcroft taldcroft deleted the fix-states-maneuver branch February 2, 2021 21:41
@javierggt javierggt mentioned this pull request Mar 2, 2021
@jeanconn jeanconn mentioned this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_continuity fails at this date
2 participants
0