Increase an ASOL quat vs OBC quat test tolerance by 4 arcsecs in roll #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
approved these changes
Dec 18, 2020
|
As expected this looks to have failed in the overnight dashboard tests so merging should at least help that right away. |
This was referenced Jan 4, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increase an ASOL quat vs OBC quat test tolerance by 4 arcsecs in roll.
The test_get_atts_time code currently runs through a bunch of machinery to compare ASOL quat with OBC quats and asserts they are within some tolerances. It looks like the released ReproV version of an ASOL in this time range has a sample that is 1 arcsec worse in roll. I've increased the tolerance from 51 to 55 in the test in this PR. I could also, for example, set the code to used a fixed version of the ASOLs, but we've recently removed "old" released ASOL files from the archive and we may continue to trim, so I think maybe it makes sense for this code always get the last released ASOL for the comparison.
Testing
No functional testing.
Fixes #