-
Notifications
You must be signed in to change notification settings - Fork 4
2021.2 #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4d95b91
to
e4cdbcd
Compare
@@ -26,6 +26,7 @@ requirements: | |||
- jupyterlab | |||
- line_profiler | |||
- lxml | |||
- mamba | |||
- matplotlib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably also pyplot
, since that is not a dependency of anything else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pyplot is not in ska3-core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or if Tom meant plotly, he already got that in in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed through this and it looks reasonable. It would be good for @jeanconn to use her eye for detail to make sure all the package numbers are right.
I didn't see Kaleido listed in the pkg_defs/ska3-core/meta.yaml file, though I did see Plotly (thank you). Kaleido is required to export Plotly-generated images to a file from a Jupyter notebook and was listed in the issue/request. If it is included in ska3-core via some other means, please disregard this message. |
Thanks for reminding me, and I am sorry I missed it. I just uploaded the package to the conda channel and modified meta.yml, so it should be available in 2021.2rc4. |
Thank You! |
…tches pkg_defs/ska3-flight/meta.yaml
ska3-flight 2021.2
Summary:
This is an update of ska3-core and ska3-flight. The most notable change is the update of astropy to version 4.2. A test installation is available for testing at
/proj/sot/ska3/test-2021.2rc5
on HEAD and GRETA linux, as announced on February 19 2021 on the chandracode distribution list.Fixes/changes to maude, kadi and chandra_aca will be briefed by Tom (shown in bold in the Code Changes section below).
This release also includes some minor fixes and changes to several packages. Two packages that can be of general use were added to ska3-core: mamba and plotly.
Interface Impacts:
astropy 4.2
astropy 4.2 introduces some API changes that ended up impacting our code in regression testing (https://docs.astropy.org/en/latest/changelog.html#id91):
Testing:
/proj/sot/ska3/flight
The one apparent failure is actually a warning due to insufficient access permissions. This test does pass if it is run with the right permissions.
/proj/sot/ska3/test-2021.2rc5
:Review
All operations critical or impacting PR's are independently and carefully reviewed. For other PR's the level of detail for review is calibrated to operations criticality. Some PR's that are confined to aspect-team-specific processing may have little to no independent review.
Deployment:
Code changes
ska3-flight changes (2021.1 -> 2021.2)
New Packages
Updated Packages
ska3-core: 2021.1 -> 2021.2
aca_view: 0.5.0 -> 0.6.0 (0.5.0 -> 0.6.0)
aca_weekly_report: 0.1.4 -> 0.1.5 (0.1.4 -> 0.1.5)
acdc: 4.7.1 -> 4.7.3 (4.7.1 -> 4.7.2 -> 4.7.3)
chandra_aca: 4.31.1 -> 4.32.0 (4.31.1 -> 4.32.0)
cxotime: 3.2.3 -> 3.2.5 (3.2.3 -> 3.2.4 -> 3.2.5)
kadi: 5.5.0 -> 5.5.1 (5.5.0 -> 5.5.1)
maude: 3.5.0 -> 3.6.0 (3.5.0 -> 3.6.0)
mica: 4.24.0 -> 4.25.0 (4.24.0 -> 4.25.0)
perigee_health_plots: 0.1.2 -> 0.1.3 (0.1.2 -> 0.1.3)
proseco: 4.11.0 -> 4.11.1 (4.11.0 -> 4.11.1)
ska.engarchive: 4.51.0 -> 4.52.0 (4.51.0 -> 4.52.0)
ska_helpers: 0.4.0 -> 0.5.0 (0.4.0 -> 0.5.0)
skare3_tools: 1.0.2 -> 1.0.3 (1.0.2 -> 1.0.3)
ska3-core changes (2021.1 -> 2021.2)
New Packages
Updated Packages
Related Issues
Fixes #555
Fixes #568
Fixes #583
Fixes #585
Fixes #587
Fixes #588
Fixes #589
Fixes #590
Fixes #591
Fixes #592
Fixes #593
Fixes #594
Fixes #595
Fixes #596
Fixes #597
Fixes #601
Fixes #602
Fixes #605
Fixes #606
Fixes #607
Fixes #608