8000 2021.2 by javierggt · Pull Request #599 · sot/skare3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

2021.2 #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 26, 2021
Merged

2021.2 #599

merged 9 commits into from
Feb 26, 2021

Conversation

javierggt
Copy link
Contributor
@javierggt javierggt commented Feb 4, 2021

ska3-flight 2021.2

Summary:

This is an update of ska3-core and ska3-flight. The most notable change is the update of astropy to version 4.2. A test installation is available for testing at /proj/sot/ska3/test-2021.2rc5 on HEAD and GRETA linux, as announced on February 19 2021 on the chandracode distribution list.

Fixes/changes to maude, kadi and chandra_aca will be briefed by Tom (shown in bold in the Code Changes section below).

This release also includes some minor fixes and changes to several packages. Two packages that can be of general use were added to ska3-core: mamba and plotly.

Interface Impacts:

astropy 4.2

astropy 4.2 introduces some API changes that ended up impacting our code in regression testing (https://docs.astropy.org/en/latest/changelog.html#id91):

  • Change Table.columns.keys() and Table.columns.values() to both return generators instead of a list. This matches the behavior for Python dict objects. [#10543]
  • The order of columns when creating a table from a list of dict may be changed. Previously, the order was alphabetical because the dict keys were assumed to be in random order. Since Python 3.7, the keys are always in order of insertion, so Table now uses the order of keys in the first row to set the column order. To alphabetize the columns to match the previous behavior, use t = t[sorted(t.colnames)]. [#10900]

Testing:

  • Final test in /proj/sot/ska3/flight
  • Automated regression testing
    The one apparent failure is actually a warning due to insufficient access permissions. This test does pass if it is run with the right permissions.
  • Testing in /proj/sot/ska3/test-2021.2rc5:

Review

All operations critical or impacting PR's are independently and carefully reviewed. For other PR's the level of detail for review is calibrated to operations criticality. Some PR's that are confined to aspect-team-specific processing may have little to no independent review.

Deployment:

  • The 2021.2 release will be promoted to the flight conda channel, and deployed on HEAD and GRETA ska3/flight after the release and products for the week are approved.

Code changes

ska3-flight changes (2021.1 -> 2021.2)

New Packages

  • jobwatch: 0.2.0

Updated Packages

  • ska3-core: 2021.1 -> 2021.2

  • aca_view: 0.5.0 -> 0.6.0 (0.5.0 -> 0.6.0)

    • PR 65 (javierggt): Fix so aca_view can realistically be used in real-time mode.
  • aca_weekly_report: 0.1.4 -> 0.1.5 (0.1.4 -> 0.1.5)

    • PR 9 (jeanconn): Update task_schedule.cfg
  • acdc: 4.7.1 -> 4.7.3 (4.7.1 -> 4.7.2 -> 4.7.3)

    • PR 60 (jeanconn): Update report link
    • PR 61 (jeanconn): Adding a couple of logging messages
  • chandra_aca: 4.31.1 -> 4.32.0 (4.31.1 -> 4.32.0)

    • PR 113 (javierggt): Fetch ACA telemetry from MAUDE using blobs
    • PR 114 (taldcroft): Add calc_target_offsets function
  • cxotime: 3.2.3 -> 3.2.5 (3.2.3 -> 3.2.4 -> 3.2.5)

    • PR 24 (taldcroft): Astropy 4.2 compatibility: modified "import erfa" statement
    • PR 25 (javierggt): Ignore ERFA dubious year warning
  • kadi: 5.5.0 -> 5.5.1 (5.5.0 -> 5.5.1)

    • PR 199 (taldcroft): Fix bug getting states starting between AOUPTARQ and AOMANUVR
  • maude: 3.5.0 -> 3.6.0 (3.5.0 -> 3.6.0)

    • PR 32 (taldcroft): Do not assign defaults for start/stop times + exception handling
    • PR 33 (taldcroft): Fix chunks query when MAUDE returns no data in last chunk
  • mica: 4.24.0 -> 4.25.0 (4.24.0 -> 4.25.0)

    • PR 255 (jeanconn): Fix script default to actually save plots
    • PR 256 (jeanconn): Skip report vv warn if no sybase passwd file for db
    • PR 257 (jeanconn): Avoid vv obspar race condition
  • perigee_health_plots: 0.1.2 -> 0.1.3 (0.1.2 -> 0.1.3)

    • PR 18 (jeanconn): Use config DAVCSDTEMP_PLOT xlim for dtemp default lims
  • proseco: 4.11.0 -> 4.11.1 (4.11.0 -> 4.11.1)

    • PR 350 (taldcroft): Fix problem from table API change in astropy 4.2
  • ska.engarchive: 4.51.0 -> 4.52.0 (4.51.0 -> 4.52.0)

    • PR 213 (taldcroft): Update flake8.yml to Python 3.8
    • PR 217 (taldcroft): Fix file_defs.py for PEP8
    • PR 215 (jeanconn): Fix sync index column order to match order from astropy 4.0
    • PR 214 (taldcroft): Retry tables open file
  • ska_helpers: 0.4.0 -> 0.5.0 (0.4.0 -> 0.5.0)

    • PR 21 (taldcroft): Add tables_open_file func to retry opening
  • skare3_tools: 1.0.2 -> 1.0.3 (1.0.2 -> 1.0.3)

    • PR 78 (javierggt): Fix release description so PR links are full URIs

ska3-core changes (2021.1 -> 2021.2)

New Packages

  • iniconfig: 1.1.1
  • krb5: 1.18.2
  • libcurl: 7.71.1
  • libsolv: 0.7.14
  • libssh2: 1.9.0
  • mamba: 0.4.2
  • plotly: 4.14.3
  • pyerfa: 1.7.1.1
  • python-kaleido: 0.0.3
  • python_abi: 3.8
  • retrying: 1.3.3

Updated Packages

  • astropy: 4.0.1.post1 -> 4.2
  • bleach: 3.1.5 -> 3.3.0
  • ca-certificates: 2020.6.24 -> 2021.1.19
  • certifi: 2020.6.20 -> 2020.12.5
  • openssl: 1.1.1g -> 1.1.1i
  • pytest: 6.2 -> 6.2.0

Related Issues

Fixes #555
Fixes #568
Fixes #583
Fixes #585
Fixes #587
Fixes #588
Fixes #589
Fixes #590
Fixes #591
Fixes #592
Fixes #593
Fixes #594
Fixes #595
Fixes #596
Fixes #597
Fixes #601
Fixes #602
Fixes #605
Fixes #606
Fixes #607
Fixes #608

@javierggt javierggt force-pushed the 2021.2 branch 2 times, most recently from 4d95b91 to e4cdbcd Compare February 4, 2021 01:55
@@ -26,6 +26,7 @@ requirements:
- jupyterlab
- line_profiler
- lxml
- mamba
- matplotlib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably also pyplot, since that is not a dependency of anything else.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyplot is not in ska3-core

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or if Tom meant plotly, he already got that in in a separate PR.

Copy link
Member
@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed through this and it looks reasonable. It would be good for @jeanconn to use her eye for detail to make sure all the package numbers are right.

@matthewdahmer
Copy link

I didn't see Kaleido listed in the pkg_defs/ska3-core/meta.yaml file, though I did see Plotly (thank you). Kaleido is required to export Plotly-generated images to a file from a Jupyter notebook and was listed in the issue/request. If it is included in ska3-core via some other means, please disregard this message.

@javierggt
Copy link
Contributor Author

I didn't see Kaleido listed in the pkg_defs/ska3-core/meta.yaml file..

Thanks for reminding me, and I am sorry I missed it. I just uploaded the package to the conda channel and modified meta.yml, so it should be available in 2021.2rc4.

@matthewdahmer
Copy link

Thank You!

@javierggt javierggt merged commit e7121a2 into master Feb 26, 2021
@javierggt javierggt mentioned this pull request Feb 26, 2021
@javierggt javierggt deleted the 2021.2 branch April 19, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants
0