Add OpInfo test to check that floating point inputs in OpInfos have requires_grad set to True #69909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equires_grad set to True This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
This was referenced Dec 14, 2021
Closed
Closed
…nfos have requires_grad set to True" This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. [ghstack-poisoned]
…nfos have requires_grad set to True" This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. [ghstack-poisoned]
…nfos have requires_grad set to True" This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. [ghstack-poisoned]
lezcano
added a commit
that referenced
this pull request
Dec 14, 2021
…equires_grad set to True This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. ghstack-source-id: 2addab5 Pull Request resolved: #69909
…nfos have requires_grad set to True" This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. [ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit c70724b (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
| Unknown | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Please report bugs/suggestions to the (internal) Dr. CI Users group.
…nfos have requires_grad set to True" This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. [ghstack-poisoned]
…nfos have requires_grad set to True" This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. [ghstack-poisoned]
…nfos have requires_grad set to True" This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. [ghstack-poisoned]
…nfos have requires_grad set to True" This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. [ghstack-poisoned]
…nfos have requires_grad set to True" This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. [ghstack-poisoned]
…nfos have requires_grad set to True" This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. [ghstack-poisoned]
…nfos have requires_grad set to True" This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. [ghstack-poisoned]
…nfos have requires_grad set to True" This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. [ghstack-poisoned]
…nfos have requires_grad set to True" This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. [ghstack-poisoned]
93 tasks
…nfos have requires_grad set to True" This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. [ghstack-poisoned]
…nfos have requires_grad set to True" This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. [ghstack-poisoned]
…nfos have requires_grad set to True" This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. [ghstack-poisoned]
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Internal tools are failing to merge the stack up to here, unfortunately, and are requesting a rebase. |
…nfos have requires_grad set to True" This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. Differential Revision: [D33774422](https://our.internmc.facebook.com/intern/diff/D33774422) [ghstack-poisoned]
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…nfos have requires_grad set to True" This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. Differential Revision: [D33774422](https://our.internmc.facebook.com/intern/diff/D33774422) [ghstack-poisoned]
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 27, 2022
…equires_grad set to True (#69909) Summary: Pull Request resolved: #69909 This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. Test Plan: Imported from OSS Reviewed By: anjali411 Differential Revision: D33774422 Pulled By: mruberry fbshipit-source-id: 76cfc75b1fdfd72ee64aa524665f83a75fe52509
alexhagiopol
pushed a commit
that referenced
this pull request
Jan 28, 2022
…equires_grad set to True (#69909) Summary: Pull Request resolved: #69909 This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. Test Plan: Imported from OSS Reviewed By: anjali411 Differential Revision: D33774422 Pulled By: mruberry fbshipit-source-id: 76cfc75b1fdfd72ee64aa524665f83a75fe52509 (cherry picked from commit 13ea7b4)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
…equires_grad set to True (#69909) Summary: Pull Request resolved: pytorch/pytorch#69909 This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. Test Plan: Imported from OSS Reviewed By: anjali411 Differential Revision: D33774422 Pulled By: mruberry fbshipit-source-id: 76cfc75b1fdfd72ee64aa524665f83a75fe52509 (cherry picked from commit 13ea7b4)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
…equires_grad set to True (#69909) Summary: Pull Request resolved: pytorch/pytorch#69909 This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. Test Plan: Imported from OSS Reviewed By: anjali411 Differential Revision: D33774422 Pulled By: mruberry fbshipit-source-id: 76cfc75b1fdfd72ee64aa524665f83a75fe52509 (cherry picked from commit 13ea7b4)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
…equires_grad set to True (#69909) Summary: Pull Request resolved: pytorch/pytorch#69909 This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. Test Plan: Imported from OSS Reviewed By: anjali411 Differential Revision: D33774422 Pulled By: mruberry fbshipit-source-id: 76cfc75b1fdfd72ee64aa524665f83a75fe52509 (cherry picked from commit 13ea7b4)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
…equires_grad set to True (#69909) Summary: Pull Request resolved: pytorch/pytorch#69909 This test detected a number of sampling methods that were not generating the samples as expected, e.g. `index_put`, `cosine_embedding`, `stft`, but perhaps most notably the generator for `BinOps`. It also detected that `reminder` and `fmod` did not have implemented the backward formula for the second input. I added this in the previous PR. Test Plan: Imported from OSS Reviewed By: anjali411 Differential Revision: D33774422 Pulled By: mruberry fbshipit-source-id: 76cfc75b1fdfd72ee64aa524665f83a75fe52509 (cherry picked from commit 13ea7b4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This test detected a number of sampling methods that were not generating
the samples as expected, e.g.
index_put,cosine_embedding,stft, butperhaps most notably the generator for
BinOps.It also detected that
reminderandfmoddid not have implemented thebackward formula for the second input. I added this in the previous PR.
Differential Revision: D33774422