Generalize noncontiguous tests to several outputs #67996
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary for most matrix decompositions in `linalg`. [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Closed
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 714d235 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
This was referenced Nov 8, 2021
Closed
Closed
This is necessary for most matrix decompositions in `linalg`. [ghstack-poisoned]
This was referenced Nov 11, 2021
This is necessary for most matrix decompositions in `linalg`. cc mruberry [ghstack-poisoned]
This is necessary for most matrix decompositions in `linalg`. cc mruberry [ghstack-poisoned]
This is necessary for most matrix decompositions in `linalg`. cc mruberry [ghstack-poisoned]
This is necessary for most matrix decompositions in `linalg`. cc mruberry [ghstack-poisoned]
This is necessary for most matrix decompositions in `linalg`. cc mruberry [ghstack-poisoned]
mruberry
reviewed
Nov 12, 2021
| if zero_dim: | ||
| t = t.unsqueeze(0) | ||
|
|
||
| # Handle conj bit. repeat_interleave resolves the conj, which is a bit annoying. |
There was a problem hiding this comment.
Actually I don't see any reason why we need to resolve conjugation or negation for repeat_interleave. We should register the repeat_interleave as fallthrough for both Conjugate and Negative dispatch key and simply unset the conj/neg bit for self before the computation and then reset it. repeats is guaranteed to be an int tensor so we don't have to worry about it.
There was a problem hiding this comment.
It might be worth making this change in this PR so that you don't have to add special conj/neg handling
This is necessary for most matrix decompositions in `linalg`. cc mruberry [ghstack-poisoned]
This is necessary for most matrix decompositions in `linalg`. cc mruberry [ghstack-poisoned]
This is necessary for most matrix decompositions in `linalg`. cc mruberry [ghstack-poisoned]
This is necessary for most matrix decompositions in `linalg`. cc mruberry [ghstack-poisoned]
This is necessary for most matrix decompositions in `linalg`. cc mruberry [ghstack-poisoned]
This is necessary for most matrix decompositions in `linalg`. cc mruberry [ghstack-poisoned]
This is necessary for most matrix decompositions in `linalg`. cc mruberry [ghstack-poisoned]
This is necessary for most matrix decompositions in `linalg`. cc mruberry [ghstack-poisoned]
This is necessary for most matrix decompositions in `linalg`. cc mruberry [ghstack-poisoned]
This is necessary for most matrix decompositions in `linalg`. cc mruberry [ghstack-poisoned]
This is necessary for most matrix decompositions in `linalg`. cc mruberry [ghstack-poisoned]
This is necessary for most matrix decompositions in `linalg`. cc mruberry [ghstack-poisoned]
|
Rebased @mruberry |
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This is necessary for most matrix decompositions in `linalg`. cc mruberry Differential Revision: [D33774418](https://our.internmc.facebook.com/intern/diff/D33774418) [ghstack-poisoned]
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This is necessary for most matrix decompositions in `linalg`. cc mruberry Differential Revision: [D33774418](https://our.internmc.facebook.com/intern/diff/D33774418) [ghstack-poisoned]
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This is necessary for most matrix decompositions in `linalg`. cc mruberry Differential Revision: [D33774418](https://our.internmc.facebook.com/intern/diff/D33774418) [ghstack-poisoned]
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 27, 2022
Summary: Pull Request resolved: #67996 This is necessary for most matrix decompositions in `linalg`. cc mruberry Test Plan: Imported from OSS Reviewed By: anjali411 Differential Revision: D33774418 Pulled By: mruberry fbshipit-source-id: 576f2dda9d484808b4acf0621514c0ffe26834e6
alexhagiopol
pushed a commit
that referenced
this pull request
Jan 28, 2022
Summary: Pull Request resolved: #67996 This is necessary for most matrix decompositions in `linalg`. cc mruberry Test Plan: Imported from OSS Reviewed By: anjali411 Differential Revision: D33774418 Pulled By: mruberry fbshipit-source-id: 576f2dda9d484808b4acf0621514c0ffe26834e6 (cherry picked from commit fb07c50)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Summary: Pull Request resolved: pytorch/pytorch#67996 This is necessary for most matrix decompositions in `linalg`. cc mruberry Test Plan: Imported from OSS Reviewed By: anjali411 Differential Revision: D33774418 Pulled By: mruberry fbshipit-source-id: 576f2dda9d484808b4acf0621514c0ffe26834e6 (cherry picked from commit fb07c50)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Summary: Pull Request resolved: pytorch/pytorch#67996 This is necessary for most matrix decompositions in `linalg`. cc mruberry Test Plan: Imported from OSS Reviewed By: anjali411 Differential Revision: D33774418 Pulled By: mruberry fbshipit-source-id: 576f2dda9d484808b4acf0621514c0ffe26834e6 (cherry picked from commit fb07c50)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#67996 This is necessary for most matrix decompositions in `linalg`. cc mruberry Test Plan: Imported from OSS Reviewed By: anjali411 Differential Revision: D33774418 Pulled By: mruberry fbshipit-source-id: 576f2dda9d484808b4acf0621514c0ffe26834e6 (cherry picked from commit fb07c50)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#67996 This is necessary for most matrix decompositions in `linalg`. cc mruberry Test Plan: Imported from OSS Reviewed By: anjali411 Differential Revision: D33774418 Pulled By: mruberry fbshipit-source-id: 576f2dda9d484808b4acf0621514c0ffe26834e6 (cherry picked from commit fb07c50)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This is necessary for most matrix decompositions in
linalg.cc @mruberry
Differential Revision: D33774418