8000 Make linalg.lu_factor structured by lezcano · Pull Request #66934 · pytorch/pytorch · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make linalg.lu_factor structured #66934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 58 commits into from
Closed

Make linalg.lu_factor structured #66934

wants to merge 58 commits into from

Conversation

lezcano
Copy link
Collaborator
@lezcano lezcano commented Oct 20, 2021 •
edited
Loading

Stack from ghstack:

cc @jianyuh @nikitaved @pearu @mruberry @walterddr @IvanYashchuk @xwang233 @lezcano

Differential Revision: D32684856

@lezcano lezcano mentioned this pull request Oct 20, 2021
Closed
@pytorch-probot
Copy link
pytorch-probot bot commented Oct 20, 2021 •
edited
Loading
CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/8140bbd8d0336dce6f8668b2f95de6691e7d1f4b/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default

Workflows Labels (bold enabled) Status
Triggered Workflows
linux-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/noarch, ciflow/trunk ✅ triggered
linux-docs ciflow/all, ciflow/cpu, ciflow/default, ciflow/docs, ciflow/linux, ciflow/trunk ✅ triggered
linux-vulkan-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk, ciflow/vulkan ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test ciflow/all, ciflow/bazel, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-build ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-asan ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/sanitizers, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-onnx ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/onnx, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc7 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
win-vs2019-cpu-py3 ciflow/all, ciflow/cpu, ciflow/default, ciflow/trunk, ciflow/win ✅ triggered
win-vs2019-cuda11.3-py3 ciflow/all, ciflow/cuda, ciflow/default, ciflow/trunk, ciflow/win ✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
docker-builds ciflow/all, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-custom-ops ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-full-jit ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-metal ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-x86-64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-x86-64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-x86-64-full-jit ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk 🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk 🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow, ciflow/trunk 🚫 skipped
linux-docs-push ciflow/all, ciflow/cpu, ciflow/linux, ciflow/scheduled 🚫 skipped
macos-10-15-py3-arm64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
macos-11-py3-x86-64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled, ciflow/slow, ciflow/slow-gradcheck 🚫 skipped
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-win-vs2019-cuda11.1-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped
periodic-win-vs2019-cuda11.5-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build ciflow/all, ciflow/android, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands: 
# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

@lezcano lezcano mentioned this pull request Oct 20, 2021
Closed
lezcano added a commit that referenced this pull request Oct 20, 2021
@lezcano
Make linalg.lu_factor structured
69a6a36 
ghstack-source-id: 485a9b7
Pull Request resolved: #66934
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Oct 20, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 8140bbd (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build linux-xenial-py3.7-clang7-asan / test (default, 1, 3, linux.2xlarge) (1/1)

Step: "Unknown" (full log | diagnosis details | 🔁 rerun)

2022-01-05T11:14:57.9130275Z SUMMARY: Undefined.../jenkins/workspace/aten/src/ATen/Utils.cpp:20:3 in 
2022-01-05T11:14:57.8584285Z     #10 0x563262e7c801 in run_mod /tmp/build/80754af9/python_1627392990942/work/Python/pythonrun.c:1037
2022-01-05T11:14:57.8585086Z     #11 0x563262e877a9 in PyRun_StringFlags /tmp/build/80754af9/python_1627392990942/work/Python/pythonrun.c:961
2022-01-05T11:14:57.8585958Z     #12 0x563262e8780b in PyRun_SimpleStringFlags /tmp/build/80754af9/python_1627392990942/work/Python/pythonrun.c:455
2022-01-05T11:14:57.8586774Z     #13 0x563262e87908 in pymain_run_command /tmp/build/80754af9/python_1627392990942/work/Modules/main.c:420
2022-01-05T11:14:57.8587496Z     #14 0x563262e87908 in pymain_run_python /tmp/build/80754af9/python_1627392990942/work/Modules/main.c:2907
2022-01-05T11:14:57.8588173Z     #15 0x563262e87908 in pymain_main /tmp/build/80754af9/python_1627392990942/work/Modules/main.c:3460
2022-01-05T11:14:57.8588841Z     #16 0x563262e87ccb in _Py_UnixMain /tmp/build/80754af9/python_1627392990942/work/Modules/main.c:3495
2022-01-05T11:14:57.9127091Z     #17 0x7fbb849e283f in __libc_start_main /build/glibc-S7Ft5T/glibc-2.23/csu/../csu/libc-start.c:291
2022-01-05T11:14:57.9128333Z     #18 0x563262e2c554 in _start (/opt/conda/bin/python3.7+0x1d7554)
2022-01-05T11:14:57.9128849Z 
2022-01-05T11:14:57.9130275Z SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:20:3 in 
2022-01-05T11:14:57.9323011Z + retcode=1
2022-01-05T11:14:57.9323757Z + set -e
2022-01-05T11:14:57.9324040Z + return 1
2022-01-05T11:14:57.9327095Z + [[ linux-xenial-py3.7-clang7-asan-default == *-NO_AVX-* ]]
2022-01-05T11:14:57.9328088Z + [[ default == \n\o\g\p\u\_\N\O\_\A\V\X ]]
2022-01-05T11:14:57.9329053Z + [[ linux-xenial-py3.7-clang7-asan-default == *-NO_AVX2-* ]]
2022-01-05T11:14:57.9329807Z + [[ default == \n\o\g\p\u\_\N\O\_\A\V\X\2 ]]
2022-01-05T11:14:57.9330627Z + [[ linux-xenial-py3.7-clang7-asan-default == *-NO_AVX512-* ]]
2022-01-05T11:14:57.9331289Z + [[ default == \n\o\g\p\u\_\N\O\_\A\V\X\5\1\2 ]]
2022-01-05T11:14:57.9332041Z + [[ linux-xenial-py3.7-clang7-asan-default == *tbb* ]]
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

lezcano added a commit that referenced this pull request Oct 20, 2021
@lezcano
10000 Make linalg.lu_factor structured
46024b1 
ghstack-source-id: 3ff3ebf
Pull Request resolved: #66934
@lezcano lezcano added the module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul label Oct 20, 2021
@lezcano lezcano removed the request for review from ezyang October 20, 2021 18:25
@lezcano lezcano added the module: structured kernels Related to new structured kernels functionality label Oct 20, 2021
@lezcano
Update on "Make linalg.lu_factor structured"
cc06781 
cc jianyuh nikitaved pearu mruberry walterddr @IvanYashchuk xwang233 @lezcano

[ghstack-poisoned]
@lezcano
Update on "Make linalg.lu_factor structured"
a3c53d3 
cc jianyuh nikitaved pearu mruberry walterddr @IvanYashchuk xwang233 @lezcano

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Oct 20, 2021
@lezcano
Make linalg.lu_factor structured
a2d4b46 
ghstack-source-id: f6d0c20
Pull Request resolved: #66934
@lezcano
Update on "Make linalg.lu_factor structured"
76255f6 
cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

[ghstack-poisoned]
@lezcano lezcano mentioned this pull request Oct 21, 2021
Closed
@lezcano
Update on "Make linalg.lu_factor structured"
4ae537d 
cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

[ghstack-poisoned]
@lezcano
Update on "Make linalg.lu_factor structured"
c6bcb43 
cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

[ghstack-poisoned]
@lezcano
Update on "Make linalg.lu_factor structured"
f79389e 
cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

[ghstack-poisoned]
@lezcano
Update on "Make linalg.lu_factor structured"
a84ca35 
cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

[ghstack-poisoned]
@lezcano
Update on "Make linalg.lu_factor structured"
cd07661 
cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

[ghstack-poisoned]
@lezcano
Update on "Make linalg.lu_factor structured"
d91ac09 
cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684856](https://our.internmc.facebook.com/intern/diff/D32684856)

[ghstack-poisoned]
@mruberry
Copy link
Collaborator
mruberry commented Dec 9, 2021

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@lezcano
Update on "Make linalg.lu_factor structured"
910beaa 
cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684856](https://our.internmc.facebook.com/intern/diff/D32684856)

[ghstack-poisoned]
@mruberry
Copy link
Collaborator

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@lezcano
Update on "Make linalg.lu_factor structured"
c997e0e 
cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684856](https://our.internmc.facebook.com/intern/diff/D32684856)

[ghstack-poisoned]
This was referenced Dec 14, 2021
Closed
Closed
@lezcano
Update on "Make linalg.lu_factor structured"
96a090e 
cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684856](https://our.internmc.facebook.com/intern/diff/D32684856)

[ghstack-poisoned]
@lezcano
Update on "Make linalg.lu_factor structured"
709ceb8 
cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684856](https://our.internmc.facebook.com/intern/diff/D32684856)

[ghstack-poisoned]
@lezcano
Update on "Make linalg.lu_factor structured"
bb9ccf9 
cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684856](https://our.internmc.facebook.com/intern/diff/D32684856)

[ghstack-poisoned]
@lezcano
Update on "Make linalg.lu_factor structured"
358392e 
cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684856](https://our.internmc.facebook.com/intern/diff/D32684856)

[ghstack-poisoned]
@mruberry
Copy link
Collaborator

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@lezcano
Update on "Make linalg.lu_factor structured"
a626af6 
cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684856](https://our.internmc.facebook.com/intern/diff/D32684856)

[ghstack-poisoned]
@mruberry
Copy link
Collaborator

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@lezcano
Update on "Make linalg.lu_factor structured"
6854e5a 
cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684856](https://our.internmc.facebook.com/intern/diff/D32684856)

[ghstack-poisoned]
@lezcano
Update on "Make linalg.lu_factor structured"
a5a867b 
cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684856](https://our.internmc.facebook.com/intern/diff/D32684856)

[ghstack-poisoned]
@lezcano
Update on "Make linalg.lu_factor structured"
8df4013 
cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684856](https://our.internmc.facebook.com/intern/diff/D32684856)

[ghstack-poisoned]
@lezcano
Update on "Make linalg.lu_factor structured"
e700993 
cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684856](https://our.internmc.facebook.com/intern/diff/D32684856)

[ghstack-poisoned]
@mruberry
Copy link
Collaborator

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@lezcano
Update on "Make linalg.lu_factor structured"
6e6be61 
cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684856](https://our.internmc.facebook.com/intern/diff/D32684856)

[ghstack-poisoned]
@mruberry
Copy link
Collaborator

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@lezcano
Update on "Make linalg.lu_factor structured"
451cc50 
cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684856](https://our.internmc.facebook.com/intern/diff/D32684856)

[ghstack-poisoned]
@mruberry
Copy link
Collaborator
mruberry commented Jan 4, 2022

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@lezcano
Update on "Make linalg.lu_factor structured"
63de3c6 
cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684856](https://our.internmc.facebook.com/intern/diff/D32684856)

[ghstack-poisoned]
@mruberry
Copy link
Collaborator
mruberry commented Jan 4, 2022

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@lezcano
Update on "Make linalg.lu_factor structured"
8140bbd 
cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684856](https://our.internmc.facebook.com/intern/diff/D32684856)

[ghstack-poisoned]
@mruberry
Copy link
Collaborator
mruberry commented Jan 5, 2022

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot deleted the gh/Lezcano/21/head branch January 9, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkaretnikov nkaretnikov nkaretnikov left review comments

@mruberry mruberry mruberry left review comments

@bdhirsh bdhirsh bdhirsh approved these changes

@IvanYashchuk IvanYashchuk IvanYashchuk approved these changes

@nikitaved nikitaved Awaiting requested review from nikitaved

Assignees
No one assigned
Labels
cla signed module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul module: structured kernels Related to new structured kernels functionality open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lezcano @facebook-github-bot @mruberry @nkaretnikov @bdhirsh @IvanYashchuk @pytorchbot
0