-
Notifications
You must be signed in to change notification settings - Fork 18
feat(cli): update cli-package commands to cmd-ts BM-1259 #3427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tawera-manaena
merged 12 commits into
master
from
feat/update-cli-package-commands-to-cmd-ts
Apr 14, 2025
Merged
feat(cli): update cli-package commands to cmd-ts BM-1259 #3427
tawera-manaena
merged 12 commits into
master
from
feat/update-cli-package-commands-to-cmd-ts
Apr 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<
8000
/div>
Wentao-Kuang
approved these changes
Apr 14, 2025
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 11, 2025
# [v8.0.0](v7.17.0...v8.0.0) **Please Note this is a work in progress release, please remain on v7 until the command line changes have been finalized** ### Bug Fixes * **cli:** update landing deploy script with new cli-config package BM-1260 ([#3431](#3431)) ([4d7e86d](4d7e86d)), closes [/github.com/linz/basemaps/blob/e527a04fec65c82f8577642493e8fcb475762243/packages/landing/scripts/deploy.mjs#L1](https://github.com//github.com/linz/basemaps/blob/e527a04fec65c82f8577642493e8fcb475762243/packages/landing/scripts/deploy.mjs/issues/L1) * ensure all linzjs packages are correctly labeled as deps ([#3439](#3439)) ([de9df87](de9df87)), closes [#3438](#3438) * ensure api key blocks are set in ci/cd ([#3442](#3442)) ([28f6403](28f6403)) ### Features * **cli-vector:** Extract cli to load schema json and prepare jobs to process vector mbtiles. BM-1267 ([#3429](#3429)) ([db113e2](db113e2)) * **cli:** add cli-config package BM-1260 ([#3428](#3428)) ([4ca5a47](4ca5a47)) * **cli:** move cogify create-config into cli-config package BM-1261 ([#3432](#3432)) ([5f72430](5f72430)) * **cli:** rename cogify package to cli-raster BM-1262 ([#3433](#3433)) ([36d4449](36d4449)) * **cli:** update cli-package commands to cmd-ts BM-1259 ([#3427](#3427)) ([46cc342](46cc342))
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 18, 2025
### [8.1.0](v8.0.0...v8.1.0) ### Bug Fixes * correct cli-config 'import' parameters ([#3445](#3445)) ([f349080](f349080)), closes [/github.com//pull/3427/commits/01a90a2b98bab02632a9637bfed2067c9c047c61#diff-48a5e932b724482f9a280931b7bb1188d26ef004b87c331aadfc7a7948ec7f70](https://github.com//github.com/linz/basemaps/pull/3427/commits/01a90a2b98bab02632a9637bfed2067c9c047c61/issues/diff-48a5e932b724482f9a280931b7bb1188d26ef004b87c331aadfc7a7948ec7f70) [/github.com/linz/basemaps-config/blob/a5b8b9baaa9941314a13058e53945bc5db5f5357/.github/workflows/build.yml#L131](https://github.com//github.com/linz/basemaps-config/blob/a5b8b9baaa9941314a13058e53945bc5db5f5357/.github/workflows/build.yml/issues/L131) * parsing of blocked api keys ([#3448](#3448)) ([ab8bf72](ab8bf72)) ### Features * **lambda-tiler:** expose configuration id and hash if present ([#3446](#3446)) ([43803b4](43803b4))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull reques
3020
t is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are in the process of migrating our Vector ETL system into Basemaps as a new package. To prepare for this migration, we are undertaking some housekeeping work (BM-1214). This pull request focuses on commands of the
cli
package.Modifications
Upgrades the following commands of the
cli
package from rushstack, to cmd-ts:packages/cli/src/cli/config/action.bundle.assets.ts
packages/cli/src/cli/config/action.bundle.ts
packages/cli/src/cli/config/action.import.ts
Deprecates the following commands of the
cli
package:packages/cli/src/cli/server/action.serve.ts
Updates the following GitHub workflows to no longer use the deprecated
action.serve.ts
command:.github/workflows/screenshot.yml
.github/workflows/smoke-test.yml
These workflows now use the
basemaps-server
CLI command of theserver
package.Updates the
cli
package's dependencies, installing those required, and uninstalled those no longer needed.Updates the
cli
package's Dockerfile to no longer install thebasemaps-landing
andbasemaps-server
assets.Intention
We intend to migrate these commands to a new package called
cli-config
in another piece of work (BM-1260). The idea for this pull request is to update the commands without introducing any breaking changes.Verification
All three of the upgraded commands work locally without issue.
The updated GitHub workflows execute and succeed without issue.